Conversation
Contributor
Author
|
Hi, the PR pass all of the CI checks. Can you merge it and publish new releases please? |
JeffLIrion
reviewed
Oct 18, 2023
|
|
||
| return constants.CMD_HDMI_INPUT | ||
|
|
||
| def _cmd_volume_set(self): |
Owner
There was a problem hiding this comment.
I think it would be simpler to take volume_level as a parameter and return the formatted string.
JeffLIrion
reviewed
Oct 18, 2023
| new_volume = int(min(max(round(self.max_volume * volume_level), 0.0), self.max_volume)) | ||
|
|
||
| await self._adb.shell("media volume --show --stream 3 --set {}".format(new_volume)) | ||
| await self._adb.shell(self._cmd_volume_set().format(new_volume)) |
Owner
There was a problem hiding this comment.
This change needs to be made in basetv_sync.py, too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add support for androidtv 12 & 13. Tested. Also changed the way to set the volume from PR #333.
Reformatted code by black formatter