Support for passing custom OS environment to Popen #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
This new code path is untested, can you add a test to make sure env vars are used as expected before merging? |
Contributor
Author
|
What kind of tests would you like other than the example I posted with the pull request? |
Collaborator
|
You could write a unit test that mocks out |
Contributor
Author
|
Would it be sufficient to show the effect of setting the PATH environment variable for |
Collaborator
|
I'll write tests for this in another PR. Thanks for the contribution! |
Contributor
Author
|
Great, thank you
… On 27 Apr 2018, at 09.42, Alan Hamlett ***@***.***> wrote:
I'll write tests for this in another PR. Thanks for the contribution!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#97 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AKq-vW7XvHW4az963SAARY7a71m_xGwrks5tssvXgaJpZM4S2l3z>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing custom environment variables such as DISPLAY to wkhtmltopdf is necessary when using pdfkit with xvfbwrapper running in a cgi / wsgi setup.
Code example for usage with Xvfb:
import pdfkit
from xvfbwrapper import Xvfb
input = "Test"
input.encode("utf8")
vdisplay = Xvfb()
vdisplay.start()
env = os.environ
env['DISPLAY'] = ":%s" % vdisplay.vdisplay_num
configuration = pdfkit.configuration(environ=env)
pdfkit.from_string(input, 'out.pdf', configuration=configuration)
vdisplay.stop()