Fix for issue #218 #221
Merged
Fix for issue #218 #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This could fix the issue as checking for python version too (https://stackoverflow.com/questions/19877306/nameerror-global-name-unicode-is-not-defined-in-python-3). I hope you guys push the fix as it breaks python optimizer. This PR fixes issue #218 (error: NameError: name 'unicode' is not defined). This error happens because Python v3 has replaced unicode with str. The problem is that if you use PYTHONOPTIMIZE then all asserts will be removed. |
|
Are you planning on merging this anytime soon? |
|
It would be amazing for this to get fixed but @JazzCore hasnt joined since november 2021 :( I hope he is doing okay! |
alanhamlett
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.