Fix plistlib loading of partial ISO 8601 dates#4
Open
JavaZeroo wants to merge 3 commits into
Open
Conversation
JavaZeroo
force-pushed
the
fix/plistlib-partial-date
branch
from
b6ad3b9 to
c2c8258
Compare
plistlib's date regex makes the month, day and time components optional, but _date_from_string stopped building the datetime arguments at the first missing component, so a partial date such as ``2024-06Z`` raised a confusing TypeError instead of producing a datetime. Default the omitted components to the start of the period.
JavaZeroo
force-pushed
the
fix/plistlib-partial-date
branch
from
c2c8258 to
526bbb5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fix
plistlib._date_from_stringraising a confusingTypeErrorwhen a<date>omits smaller units (e.g.2024-06Zor2024Z). The date regex makes month/day/time optional, but the argument list fordatetime.datetime()was truncated at the first missing component. Missing components now default to the start of the period.Add coverage for loading partial dates (year only, year-month, etc.).
Tests: