Feature/own http client#1
Merged
Merged
Conversation
Member
Author
|
Cookies are not yet processed |
x7airworker
previously approved these changes
Dec 5, 2021
Member
Author
|
I abstracted the http implementation now and set the default back to java.net.HttpUrlConnection however the user can choose to use the currently experimental "Simple" implementation as well as Apache HttpClient or even custom implementations. I also thought about implementing OkHttp as is it's another major Http Library but Apache is a solid ground and in case users really need it, it can be implemented in a single class by the user. Cookie support is also done independent of the implementation now so it should work for all 3 implementations. |
x7airworker
approved these changes
Jan 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements an own http client and adds web socket support. The old HttpUrlConnection based client can still be used by setting
.legacyMode()on the client but for websocket connections it will always use the new one.