Skip to content

Commit f364949

Browse files
committed
Warn when using the Buffer constructor
1 parent d5be8cd commit f364949

File tree

1 file changed

+19
-0
lines changed

1 file changed

+19
-0
lines changed

etc/eslint/rules/nodejs.js

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,25 @@ rules[ 'global-require' ] = 'off';
8787
*/
8888
rules[ 'handle-callback-err' ] = [ 'error', '^(err|error)$' ];
8989

90+
/**
91+
* Warn when using the `Buffer` constructor.
92+
*
93+
* @name no-buffer-constructor
94+
* @memberof rules
95+
* @type {string}
96+
* @default 'warn'
97+
* @see [no-buffer-constructor]{@link http://eslint.org/docs/rules/no-buffer-constructor}
98+
*
99+
* @example
100+
* // Bad...
101+
* var buf = new Buffer( [ 1, 2, 3 ] );
102+
*
103+
* @example
104+
* // Good...
105+
* var buf = Buffer.from( [ 1, 2, 3 ] );
106+
*/
107+
rules[ 'no-buffer-constructor' ] = 'warn'; // TODO: revisit once all Buffer usage includes support for older Node versions
108+
90109
/**
91110
* Only allow `require`d modules to be grouped together.
92111
*

0 commit comments

Comments
 (0)