Move finding a command to a function

kgryte · kgryte · commit f1f2aa4aa83b · 2018-05-03T09:28:46.000-07:00
diff --git a/bin/cli b/bin/cli
@@ -44,6 +44,17 @@ function onError( error ) {
 	console.error( 'Error: %s', error.message ); // eslint-disable-line no-console
 }
 
+/**
+* Finds a command in the command list.
+*
+* @private
+* @param {string} name - command name
+* @returns {(Object|null)} command info
+*/
+function findCommand( name ) {
+	return COMMANDS[ name ] || null;
+}
+
 
 // MAIN //
 
@@ -78,15 +89,15 @@ function main() {
 		if ( args[ 1 ] === void 0 ) {
 			return cli.help();
 		}
-		cmd = COMMANDS[ args[ 1 ] ];
-		if ( cmd === void 0 ) {
+		cmd = findCommand( args[ 1 ] );;
+		if ( cmd === null ) {
 			return onError( new Error( 'invalid argument. Unrecognized/unsupported command. Value: `' + args[ 1 ] + '`.' ) );
 		}
 		cmd = resolve( __dirname, '..', cmd.path );
 		subargs = [ cmd, '--help' ];
 	} else {
-		cmd = COMMANDS[ args[ 0 ] ];
-		if ( cmd === void 0 ) {
+		cmd = findCommand( args[ 0 ] );;
+		if ( cmd === null ) {
 			return onError( new Error( 'invalid argument. Unrecognized/unsupported command. Value: `' + args[ 0 ] + '`.' ) );
 		}
 		cmd = resolve( __dirname, '..', cmd.path );
diff --git a/bin/commands.json b/bin/commands.json
@@ -1,29 +1,36 @@
 {
+	"help [command]": {
+		"cmd": "help [command]",
+		"desc": "Print a help message.",
+		"path": ""
+	},
 	"bundle-pkg-list": {
+		"cmd": "bundle-pkg-list",
 		"desc": "Bundle a list of packages into a single file.",
 		"path": "./lib/node_modules/@stdlib/_tools/bundle/pkg-list/bin/cli"
 	},
 	"datasets": {
+		"cmd": "datasets",
 		"desc": "Retrieve a dataset.",
 		"path": "./lib/node_modules/@stdlib/datasets/bin/cli"
 	},
-	"help [command]": {
-		"desc": "Print a help message.",
-		"path": ""
-	},
 	"ls": {
+		"cmd": "ls",
 		"desc": "List package names.",
 		"path": "./lib/node_modules/@stdlib/_tools/pkgs/names/bin/cli"
 	},
 	"ls-tree": {
+		"cmd": "ls-tree",
 		"desc": "Show package tree.",
 		"path": "./lib/node_modules/@stdlib/_tools/pkgs/tree/bin/cli"
 	},
 	"ns": {
+		"cmd": "ns",
 		"desc": "Print namespace.",
 		"path": "./lib/node_modules/@stdlib/namespace/bin/cli"
 	},
 	"repl": {
+		"cmd": "repl",
 		"desc": "Start a REPL.",
 		"path": "./lib/node_modules/@stdlib/repl/bin/cli"
 	}
