Refactor to ignore iterator return values

kgryte · kgryte · commit e75cfe50a4b9 · 2021-12-15T21:04:59.000-08:00
diff --git a/lib/node_modules/@stdlib/iter/for-each/lib/main.js b/lib/node_modules/@stdlib/iter/for-each/lib/main.js
@@ -23,7 +23,6 @@
 var setReadOnly = require( '@stdlib/utils/define-nonenumerable-read-only-property' );
 var isFunction = require( '@stdlib/assert/is-function' );
 var isIteratorLike = require( '@stdlib/assert/is-iterator-like' );
-var hasOwnProp = require( '@stdlib/assert/has-own-property' );
 var iteratorSymbol = require( '@stdlib/symbol/iterator' );
 
 
@@ -92,7 +91,6 @@ function iterForEach( iterator, fcn, thisArg ) {
 	* @returns {Object} iterator protocol-compliant object
 	*/
 	function next() {
-		var out;
 		var v;
 		i += 1;
 		if ( FLG ) {
@@ -103,14 +101,7 @@ function iterForEach( iterator, fcn, thisArg ) {
 		v = iterator.next();
 		if ( v.done ) {
 			FLG = true;
-			out = {};
-			if ( hasOwnProp( v, 'value' ) ) {
-				v = v.value;
-				fcn.call( thisArg, v, i );
-				out.value = v;
-			}
-			out.done = true;
-			return out;
+			return v;
 		}
 		v = v.value;
 		fcn.call( thisArg, v, i );
diff --git a/lib/node_modules/@stdlib/iter/for-each/test/test.js b/lib/node_modules/@stdlib/iter/for-each/test/test.js
@@ -119,81 +119,6 @@ tape( 'the function returns an iterator protocol-compliant object', function tes
 	}
 });
 
-tape( 'the function returns an iterator protocol-compliant object (value+done)', function test( t ) {
-	var expected;
-	var actual;
-	var values;
-	var count;
-	var it;
-	var i;
-
-	values = [ 1, 2, 3, 4 ];
-	expected = [
-		{
-			'value': 1,
-			'done': false
-		},
-		{
-			'value': 2,
-			'done': false
-		},
-		{
-			'value': 3,
-			'done': false
-		},
-		{
-			'value': 4,
-			'done': true
-		}
-	];
-
-	it = iterForEach( createIterator( values ), assert );
-	t.equal( it.next.length, 0, 'has zero arity' );
-
-	actual = [];
-	count = 0;
-	for ( i = 0; i < values.length; i++ ) {
-		actual.push( it.next() );
-	}
-	t.deepEqual( actual, expected, 'returns expected values' );
-	t.equal( count, values.length, 'returns expected value' );
-	t.end();
-
-	function assert( v, i ) {
-		count += 1;
-		t.equal( isnan( v ), false, 'is not NaN' );
-		t.equal( isnan( i ), false, 'is not NaN' );
-	}
-
-	function createIterator( arr ) {
-		var len;
-		var it;
-		var i;
-
-		len = arr.length;
-		i = -1;
-
-		it = {};
-		it.next = next;
-
-		return it;
-
-		function next() {
-			var out;
-			i += 1;
-			if ( i < len ) {
-				out = {};
-				out.value = arr[ i ];
-				out.done = ( i === len-1 );
-				return out;
-			}
-			return {
-				'done': true
-			};
-		}
-	}
-});
-
 tape( 'the function returns an iterator protocol-compliant object which invokes a provided function for each iterated value before returning the iterated value', function test( t ) {
 	var expected;
 	var opts;
