build: enable fast failing by default

kgryte · kgryte · commit cc39c9e9e151 · 2024-03-21T20:36:11.000-07:00
diff --git a/tools/make/lib/install/addons.mk b/tools/make/lib/install/addons.mk
@@ -61,6 +61,21 @@ install_node_addons_list_addons_flags := "--pattern $(node_addons_pattern)"
 # make install-node-addons
 #/
 install-node-addons: $(NODE_MODULES) clean-node-addons
+ifeq ($(FAIL_FAST), true)
+	$(QUIET) $(MAKE) LIST_PKGS_ADDONS_FLAGS=$(install_node_addons_list_addons_flags) -f $(this_file) list-pkgs-addons | while read -r pkg; do \
+		if echo "$$pkg" | grep -v '^\/.*\|^[a-zA-Z]:.*' >/dev/null; then \
+			continue; \
+		fi; \
+		echo ''; \
+		echo "Building add-on: $$pkg"; \
+		cd $$pkg && \
+			MAKEFLAGS= \
+			NODE_PATH="$(NODE_PATH)" \
+			GYP_DEFINES="$(NODE_GYP_DEFINES)" \
+			$(NODE_GYP) $(NODE_GYP_FLAGS) rebuild \
+		|| { echo "Error: failed to build add-on: $$pkg"; exit 1; } \
+	done
+else
 	$(QUIET) $(MAKE) LIST_PKGS_ADDONS_FLAGS=$(install_node_addons_list_addons_flags) -f $(this_file) list-pkgs-addons | while read -r pkg; do \
 		if echo "$$pkg" | grep -v '^\/.*\|^[a-zA-Z]:.*' >/dev/null; then \
 			continue; \
@@ -74,6 +89,7 @@ install-node-addons: $(NODE_MODULES) clean-node-addons
 			$(NODE_GYP) $(NODE_GYP_FLAGS) rebuild \
 		|| { echo "Error: failed to build add-on: $$pkg"; exit 0; } \
 	done
+endif
 
 .PHONY: install-node-addons
 
@@ -83,7 +99,19 @@ install-node-addons: $(NODE_MODULES) clean-node-addons
 # @example
 # make clean-node-addons
 #/
-clean-node-addons:
+clean-node-addons: $(NODE_MODULES)
+ifeq ($(FAIL_FAST), true)
+	$(QUIET) $(MAKE) LIST_PKGS_ADDONS_FLAGS=$(install_node_addons_list_addons_flags) -f $(this_file) list-pkgs-addons | while read -r pkg; do \
+		if echo "$$pkg" | grep -v '^\/.*\|^[a-zA-Z]:.*' >/dev/null; then \
+			continue; \
+		fi; \
+		echo ''; \
+		echo "Cleaning add-on: $$pkg"; \
+		cd $$pkg/src && $(MAKE) clean && \
+		cd $$pkg && $(NODE_GYP) clean \
+		|| { echo "Error: failed to clean add-on: $$pkg"; exit 1; } \
+	done
+else
 	$(QUIET) $(MAKE) LIST_PKGS_ADDONS_FLAGS=$(install_node_addons_list_addons_flags) -f $(this_file) list-pkgs-addons | while read -r pkg; do \
 		if echo "$$pkg" | grep -v '^\/.*\|^[a-zA-Z]:.*' >/dev/null; then \
 			continue; \
@@ -94,5 +122,6 @@ clean-node-addons:
 		cd $$pkg && $(NODE_GYP) clean \
 		|| { echo "Error: failed to clean add-on: $$pkg"; exit 0; } \
 	done
+endif
 
 .PHONY: clean-node-addons
