Refactor setting of default value

kgryte · kgryte · commit a5d5b5f661a3 · 2018-02-14T22:26:41.000-08:00
diff --git a/tools/make/common.mk b/tools/make/common.mk
@@ -40,7 +40,11 @@ KEYWORDS ?= 'TODO|FIXME|WARNING|HACK|NOTE|OPTIMIZE'
 ifndef FAST_FAIL
 	FAIL_FAST := true
 else
+ifeq ($(FAST_FAIL), 0)
 	FAIL_FAST := false
+else
+	FAIL_FAST := true
+endif
 endif
 
 
diff --git a/tools/make/lib/lint/javascript/eslint.mk b/tools/make/lib/lint/javascript/eslint.mk
@@ -56,11 +56,20 @@ ESLINT_FLAGS ?= \
 # This target lints only JavaScript source files.
 
 eslint-src: $(NODE_MODULES)
+ifeq ($(FAIL_FAST), true)
 	$(QUIET) $(FIND_SOURCES_CMD) | grep '^[\/]\|^[a-zA-Z]:[/\]' | while read -r file; do \
 		echo ''; \
 		echo "Linting file: $$file"; \
 		$(ESLINT) $(ESLINT_FLAGS) --config $(ESLINT_CONF) $$file || exit 1; \
 	done
+else
+	$(QUIET) EXIT_CODE=0 && $(FIND_SOURCES_CMD) | grep '^[\/]\|^[a-zA-Z]:[/\]' | while read -r file; do \
+		echo ''; \
+		echo "Linting file: $$file"; \
+		$(ESLINT) $(ESLINT_FLAGS) --config $(ESLINT_CONF) $$file || { EXIT_CODE=1; exit 0; } \
+	done
+	exit $(EXIT_CODE)
+endif
 
 .PHONY: eslint-src
 
