fix: support collections with unknown data types

kgryte · kgryte · commit 778764b2749e · 2024-06-17T22:14:19.000-07:00
diff --git a/lib/node_modules/@stdlib/array/put/lib/main.js b/lib/node_modules/@stdlib/array/put/lib/main.js
@@ -96,8 +96,8 @@ function put( x, indices, values ) {
 			throw err;
 		}
 	}
-	xdt = dtype( x );
-	vdt = dtype( values );
+	xdt = dtype( x ) || 'generic';
+	vdt = dtype( values ) || 'generic';
 
 	// Safe casts are always allowed and allow same kind casts (i.e., downcasts) only when the input array data type is floating-point...
 	if ( !isMostlySafeCast( vdt, xdt ) ) {
diff --git a/lib/node_modules/@stdlib/array/put/test/test.js b/lib/node_modules/@stdlib/array/put/test/test.js
@@ -34,6 +34,7 @@ var zeros = require( '@stdlib/array/zeros' );
 var toAccessorArray = require( '@stdlib/array/base/to-accessor-array' );
 var isSameComplex64Array = require( '@stdlib/assert/is-same-complex64array' );
 var isSameComplex128Array = require( '@stdlib/assert/is-same-complex128array' );
+var isAccessorArray = require( '@stdlib/assert/is-accessor-array' );
 var put = require( './../lib' );
 
 
@@ -432,6 +433,80 @@ tape( 'the function replaces elements in an array (generic, broadcasting)', func
 	t.end();
 });
 
+tape( 'the function replaces elements in an array (accessors, generic)', function test( t ) {
+	var expected;
+	var indices;
+	var actual;
+	var x;
+
+	x = [ 1, 2, 3, 4 ];
+	indices = toAccessorArray( [ 1, 3 ] );
+	actual = put( toAccessorArray( x ), indices, toAccessorArray( [ 20, 40 ] ) );
+	expected = [ 1, 20, 3, 40 ];
+	t.strictEqual( isAccessorArray( actual ), true, 'returns expected value' );
+	t.deepEqual( x, expected, 'returns expected value' );
+
+	x = [ 1, 2, 3, 4 ];
+	indices = toAccessorArray( [ 1, 1, 3, 3 ] );
+	actual = put( toAccessorArray( x ), indices, toAccessorArray( [ 20, 30, 40, 50 ] ) );
+	expected = [ 1, 30, 3, 50 ];
+	t.strictEqual( isAccessorArray( actual ), true, 'returns expected value' );
+	t.deepEqual( x, expected, 'returns expected value' );
+
+	x = [ 1, 2, 3, 4 ];
+	indices = toAccessorArray( [ 3, 2, 1, 0 ] );
+	actual = put( toAccessorArray( x ), indices, toAccessorArray( [ 20, 30, 40, 50 ] ) );
+	expected = [ 50, 40, 30, 20 ];
+	t.strictEqual( isAccessorArray( actual ), true, 'returns expected value' );
+	t.deepEqual( x, expected, 'returns expected value' );
+
+	x = [ 1, 2, 3, 4 ];
+	indices = toAccessorArray( [ 1, 1, 1, 1, 1, 1, 1, 1, 1, 1 ] );
+	actual = put( toAccessorArray( x ), indices, toAccessorArray( [ 100, 100, 100, 100, 100, 100, 100, 100, 100, 100 ] ) );
+	expected = [ 1, 100, 3, 4 ];
+	t.strictEqual( isAccessorArray( actual ), true, 'returns expected value' );
+	t.deepEqual( x, expected, 'returns expected value' );
+
+	t.end();
+});
+
+tape( 'the function replaces elements in an array (accessors, generic, broadcasting)', function test( t ) {
+	var expected;
+	var indices;
+	var actual;
+	var x;
+
+	x = [ 1, 2, 3, 4 ];
+	indices = toAccessorArray( [ 1, 3 ] );
+	actual = put( toAccessorArray( x ), indices, toAccessorArray( [ 20 ] ) );
+	expected = [ 1, 20, 3, 20 ];
+	t.strictEqual( isAccessorArray( actual ), true, 'returns expected value' );
+	t.deepEqual( x, expected, 'returns expected value' );
+
+	x = [ 1, 2, 3, 4 ];
+	indices = toAccessorArray( [ 1, 1, 3, 3 ] );
+	actual = put( toAccessorArray( x ), indices, toAccessorArray( [ 20 ] ) );
+	expected = [ 1, 20, 3, 20 ];
+	t.strictEqual( isAccessorArray( actual ), true, 'returns expected value' );
+	t.deepEqual( x, expected, 'returns expected value' );
+
+	x = [ 1, 2, 3, 4 ];
+	indices = toAccessorArray( [ 3, 2, 1, 0 ] );
+	actual = put( toAccessorArray( x ), indices, toAccessorArray( [ 20 ] ) );
+	expected = [ 20, 20, 20, 20 ];
+	t.strictEqual( isAccessorArray( actual ), true, 'returns expected value' );
+	t.deepEqual( x, expected, 'returns expected value' );
+
+	x = [ 1, 2, 3, 4 ];
+	indices = toAccessorArray( [ 1, 1, 1, 1, 1, 1, 1, 1, 1, 1 ] );
+	actual = put( toAccessorArray( x ), indices, toAccessorArray( [ 100 ] ) );
+	expected = [ 1, 100, 3, 4 ];
+	t.strictEqual( isAccessorArray( actual ), true, 'returns expected value' );
+	t.deepEqual( x, expected, 'returns expected value' );
+
+	t.end();
+});
+
 tape( 'the function replaces elements in an array (int32)', function test( t ) {
 	var expected;
 	var indices;

Original file line number	Diff line number	Diff line change
`@@ -96,8 +96,8 @@ function put( x, indices, values ) {`
`96`	`96`	`throw err;`
`97`	`97`	`}`
`98`	`98`	`}`
`99`		`- xdt = dtype( x );`
`100`		`- vdt = dtype( values );`
	`99`	`+ xdt = dtype( x ) \|\| 'generic';`
	`100`	`+ vdt = dtype( values ) \|\| 'generic';`
`101`	`101`
`102`	`102`	`// Safe casts are always allowed and allow same kind casts (i.e., downcasts) only when the input array data type is floating-point...`
`103`	`103`	`if ( !isMostlySafeCast( vdt, xdt ) ) {`