Rename file, use base array utility, add todo, and fix failing tests

kgryte · kgryte · commit 58a8f3871a46 · 2022-12-08T21:33:38.000-08:00
diff --git a/lib/node_modules/@stdlib/math/tools/unary/lib/main.js b/lib/node_modules/@stdlib/math/tools/unary/lib/main.js
@@ -133,7 +133,7 @@ function dispatch( table, options ) {
 	* @throws {TypeError} must provide valid options
 	* @returns {(ndarray|Collection|number|Complex)} results
 	*/
-	function dispatcher( x, options ) {
+	function dispatcher( x ) {
 		var xdtype;
 		var ydtype;
 		var opts;
@@ -153,7 +153,7 @@ function dispatch( table, options ) {
 		}
 		opts = {};
 		if ( arguments.length > 1 ) {
-			err = validate( opts, options );
+			err = validate( opts, arguments[ 1 ] );
 			if ( err ) {
 				throw err;
 			}
@@ -172,9 +172,7 @@ function dispatch( table, options ) {
 			xdtype = dtype( x ) || 'generic';
 			ydtype = opts.dtype || odtype( xdtype, OPTS.policy );
 			y = buffer( ydtype, x.length );
-
-			// FIXME: need to supply dtype enum argument for each array argument...
-			t.array( x.length, x, 1, y, 1 );
+			t.array( x.length, xdtype, x, 1, ydtype, y, 1 );
 			return y;
 		}
 		throw new TypeError( format( 'invalid argument. Must provide an argument having a supported data type. Value: `%s`.', x ) );
@@ -226,8 +224,7 @@ function dispatch( table, options ) {
 				if ( y.length !== x.length ) {
 					throw new RangeError( 'invalid argument. Output array must have the same number of elements (i.e., length) as the input array.' );
 				}
-				// FIXME: need to supply dtype enum argument for each array argument...
-				t.array( x.length, x, 1, y, 1 );
+				t.array( x.length, dtype( x ) || 'generic', x, 1, dtype( y ) || 'generic', y, 1 );
 				return y;
 			}
 			throw new TypeError( 'invalid argument. If the first argument is an array-like object, the second argument must be an array-like object.' );
diff --git a/lib/node_modules/@stdlib/math/tools/unary/lib/ndarray.js b/lib/node_modules/@stdlib/math/tools/unary/lib/ndarray.js
@@ -24,27 +24,7 @@ var ndarray = require( '@stdlib/ndarray/ctor' );
 var buffer = require( '@stdlib/ndarray/base/buffer' );
 var shape2strides = require( '@stdlib/ndarray/base/shape2strides' );
 var numel = require( '@stdlib/ndarray/base/numel' );
-
-
-// FUNCTIONS //
-
-/**
-* Copies an array-like object to a generic array.
-*
-* @private
-* @param {ArrayLikeObject} x - input array
-* @returns {Array} output array
-*/
-function copy( x ) {
-	var out;
-	var i;
-
-	out = [];
-	for ( i = 0; i < x.length; i++ ) {
-		out.push( x[ i ] );
-	}
-	return out;
-}
+var copy = require( '@stdlib/array/base/copy-indexed' );
 
 
 // MAIN //
diff --git a/lib/node_modules/@stdlib/math/tools/unary/lib/resolve_output_dtype.js b/lib/node_modules/@stdlib/math/tools/unary/lib/resolve_output_dtype.js
@@ -39,10 +39,13 @@ function resolve( xdtype, policy ) {
 	case 'same':
 		return xdtype;
 	case 'float':
+		// TODO: we may want to delegate checking for a floating-point dtype to a utility function/package (e.g., isFloatDtype), in order to centralize logic for testing whether a dtype is "floating-point". Otherwise, this will be yet another place to update logic should we ever add, e.g., a `float128` or `float16` dtype.
 		if (
 			xdtype === 'float64' ||
 			xdtype === 'float32' ||
-			xdtype === 'generic'
+			xdtype === 'generic' ||
+			xdtype === 'complex128' ||
+			xdtype === 'complex64'
 		) {
 			return xdtype;
 		}
diff --git a/lib/node_modules/@stdlib/math/tools/unary/test/test.js b/lib/node_modules/@stdlib/math/tools/unary/test/test.js
@@ -22,7 +22,6 @@
 
 var tape = require( 'tape' );
 var Float64Array = require( '@stdlib/array/float64' );
-var Int32Array = require( '@stdlib/array/int32' );
 var array = require( '@stdlib/ndarray/array' );
 var ndarray = require( '@stdlib/ndarray/ctor' );
 var shape2strides = require( '@stdlib/ndarray/base/shape2strides' );
@@ -56,10 +55,10 @@ tape( 'the function throws an error if provided an invalid table object', functi
 		void 0,
 		[],
 		{
-			'scalar': null
+			'complex': {}
 		},
 		{
-			'scalar': [ 'number' ]
+			'number': [ 'number' ]
 		},
 		{
 			'array': {}
@@ -408,52 +407,4 @@ tape( 'the function returns a function which supports operating on an ndarray (n
 	t.end();
 });
 
-tape( 'the function returns a function which defaults to a "generic" implementation if unable to resolve a function corresponding to an array-like object\'s underlying data type', function test( t ) {
-	var expected;
-	var values;
-	var abs;
-
-	abs = dispatch( table );
-
-	values = new Int32Array([
-		-1.0,
-		-3.0,
-		2.0
-	]);
-	expected = new Int32Array([
-		1.0,
-		3.0,
-		2.0
-	]);
-	t.deepEqual( abs( values ), expected, 'returns expected value' );
-	t.end();
-});
-
-tape( 'the function returns a function which defaults to a "generic" implementation if unable to resolve a function corresponding to an ndarray\'s underlying data type', function test( t ) {
-	var expected;
-	var values;
-	var abs;
-
-	abs = dispatch( table );
-
-	values = new Int32Array([
-		-1.0,
-		-3.0,
-		2.0
-	]);
-	values = array( values, {
-		'dtype': 'int32'
-	});
-	expected = new Int32Array([
-		1.0,
-		3.0,
-		2.0
-	]);
-	expected = array( expected, {
-		'dtype': 'int32'
-	});
-	t.deepEqual( abs( values ), expected, 'returns expected value' );
-	t.end();
-});
-
 // TODO: add tests for complex numbers
diff --git a/lib/node_modules/@stdlib/math/tools/unary/test/test.validate.js b/lib/node_modules/@stdlib/math/tools/unary/test/test.validate.js
diff --git a/lib/node_modules/@stdlib/math/tools/unary/test/test.validate_table.js b/lib/node_modules/@stdlib/math/tools/unary/test/test.validate_table.js
