Fix lint errors

Planeshifter · Planeshifter · commit 386605e97244 · 2018-01-27T23:25:33.000-05:00
diff --git a/tools/search/create/lib/extractor.js b/tools/search/create/lib/extractor.js
@@ -23,22 +23,30 @@ function getSectionNodes( ast, name ) {
 	var nodes = [];
 	var scope = null;
 	visit( ast, replacer );
+
 	/**
 	* Replaces AST by the nodes of the specified section.
 	*
 	* @private
 	* @param {Node} node - reference node
 	* @param {number} index - position of `node` in `parent`
-	* @param {Node} - parent - parent of `node`
+	* @param {Node} parent - parent of `node`
 	*/
 	function replacer( node, index, parent ) {
-		var type = isSectionTag( node );
+		var type;
+		var arr;
+
+		type = isSectionTag( node );
 		if ( scope && parent === scope ) {
 			if ( type === 'end' ) {
 				if ( nodes ) {
 					// Replace scope by nodes belonging to the given section...
-					nodes = [ { type: 'root', children: nodes } ];
-					splice.apply( scope.children, [ 0, scope.children.length ].concat( nodes ) );
+					nodes = [{
+						'type': 'root',
+						'children': nodes
+					}];
+					arr = [ 0, scope.children.length ].concat( nodes );
+					splice.apply( scope.children, arr );
 				}
 				scope = null;
 				nodes = [];
@@ -66,7 +74,7 @@ function getSectionNodes( ast, name ) {
 		) {
 			return 'start';
 		}
-		else if (
+		if (
 			node.type === 'html' &&
 			node.value === '<!-- /.'+name+' -->'
 		) {
@@ -84,7 +92,7 @@ function getSectionNodes( ast, name ) {
 *
 * @private
 * @param {string} name - section name
-* @param {Function} remark attacher function
+* @returns {Function} remark attacher function
 */
 function extractor( name ) {
 	/**
@@ -96,17 +104,18 @@ function extractor( name ) {
 	function transformer( ast ) {
 		getSectionNodes( ast, name );
 	}
+	return attacher;
 
 	/**
 	* Attach a plugin to a remark processor in order to extract the specified section.
 	*
 	* @private
 	* @returns {Function} transformer
 	*/
-	return function attacher() {
+	function attacher() {
 		return transformer;
-	}; // end FUNCTION attacher()
-};
+	}
+}
 
 
 // EXPORTS //
diff --git a/tools/test-cov/tape-istanbul/lib/create_require.js b/tools/test-cov/tape-istanbul/lib/create_require.js
@@ -45,23 +45,26 @@ function createRequire( id ) {
 	*
 	* @private
 	* @param {string} path - module id
+	* @returns {void}
 	*/
 	function require( path ) {
 		try {
 			return module.require( path );
 		} finally {}
 	}
 
+	require.resolve = resolve;
+
 	/**
 	* Attempts to resolve a module.
 	*
 	* @private
 	* @param {string} name - module
 	* @returns {string} module filepath
 	*/
-	require.resolve = function resolve( name ) {
+	function resolve( name ) {
 		return resolveFilename( name, module, false );
-	}; // end FUNCTION resolve()
+	}
 
 	// Application entry point:
 	require.main = main;
diff --git a/tools/test-cov/tape-istanbul/lib/runner.js b/tools/test-cov/tape-istanbul/lib/runner.js
@@ -96,6 +96,7 @@ function runner() {
 	* @private
 	* @param {(Error|null)} error - error object
 	* @param {StringArray} files - absolute filepaths for filenames which matched the glob pattern
+	* @returns {void}
 	*/
 	function onGlob( error, files ) {
 		if ( error ) {
@@ -123,7 +124,7 @@ function runner() {
 		count = 0;
 		cache = {};
 		for ( i = 0; i < files.length; i++ ) {
-			cb = onRead( files[ i ], onData );
+			cb = onReadFactory( files[ i ], onData );
 			readFile( files[ i ], opts, cb );
 		}
 		/**
@@ -148,21 +149,24 @@ function runner() {
 	* @private
 	* @param {string} id - file id
 	* @param {Callback} clbk - callback
+	* @returns {void}
 	*/
-	function onRead( id, clbk ) {
+	function onReadFactory( id, clbk ) {
+		return onRead;
 		/**
 		* Callback invoked upon reading a file.
 		*
 		* @private
 		* @param {(Error|null)} error - error object
 		* @param {(Buffer|string)} data - file content
+		* @returns {void}
 		*/
-		return function onRead( error, data ) {
+		function onRead( error, data ) {
 			if ( error ) {
 				return done( error );
 			}
 			clbk( id, data.toString() );
-		}; // end FUNCTION onRead()
+		}
 	}
 
 	/**
@@ -214,6 +218,7 @@ function runner() {
 	*
 	* @private
 	* @param {Error} [error] - error object
+	* @returns {void}
 	*/
 	function done( error ) {
 		if ( error ) {
