Skip to content

Commit 2b57f34

Browse files
kgrytekgryte
committed
refactor: update implementation according to current project conventions
Ref: stdlib-js#788
1 parent 2705ac1 commit 2b57f34

25 files changed

+300
-384
lines changed

‎lib/node_modules/@stdlib/blas/base/dnrm2/README.md‎

Lines changed: 10 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,8 @@ Computes the [L2-norm][l2-norm] of a double-precision floating-point vector `x`.
5555
var Float64Array = require( '@stdlib/array/float64' );
5656

5757
var x = new Float64Array( [ 1.0, -2.0, 2.0 ] );
58-
var N = 3;
5958

60-
var z = dnrm2( N, x, 1 );
59+
var z = dnrm2( 3, x, 1 );
6160
// returns 3.0
6261
```
6362

@@ -71,12 +70,10 @@ The `N` and `stride` parameters determine which elements in `x` are accessed at
7170

7271
```javascript
7372
var Float64Array = require( '@stdlib/array/float64' );
74-
var floor = require( '@stdlib/math/base/special/floor' );
7573

7674
var x = new Float64Array( [ 1.0, 2.0, 2.0, -7.0, -2.0, 3.0, 4.0, 2.0 ] );
77-
var N = floor( x.length / 2 );
7875

79-
var z = dnrm2( N, x, 2 );
76+
var z = dnrm2( 4, x, 2 );
8077
// returns 5.0
8178
```
8279

@@ -90,9 +87,7 @@ var Float64Array = require( '@stdlib/array/float64' );
9087
var x0 = new Float64Array( [ 2.0, 1.0, 2.0, -2.0, -2.0, 2.0, 3.0, 4.0 ] );
9188
var x1 = new Float64Array( x0.buffer, x0.BYTES_PER_ELEMENT*1 ); // start at 2nd element
9289

93-
var N = 4;
94-
95-
var z = dnrm2( N, x1, 2 );
90+
var z = dnrm2( 4, x1, 2 );
9691
// returns 5.0
9792
```
9893

@@ -106,9 +101,8 @@ Computes the [L2-norm][l2-norm] of a double-precision floating-point vector usin
106101
var Float64Array = require( '@stdlib/array/float64' );
107102

108103
var x = new Float64Array( [ 1.0, -2.0, 2.0 ] );
109-
var N = 3;
110104

111-
var z = dnrm2.ndarray( N, x, 1, 0 );
105+
var z = dnrm2.ndarray( 3, x, 1, 0 );
112106
// returns 3.0
113107
```
114108

@@ -120,12 +114,10 @@ While [`typed array`][mdn-typed-array] views mandate a view offset based on the
120114

121115
```javascript
122116
var Float64Array = require( '@stdlib/array/float64' );
123-
var floor = require( '@stdlib/math/base/special/floor' );
124117

125118
var x = new Float64Array( [ 2.0, 1.0, 2.0, -2.0, -2.0, 2.0, 3.0, 4.0 ] );
126-
var N = floor( x.length / 2 );
127119

128-
var z = dnrm2.ndarray( N, x, 2, 1 );
120+
var z = dnrm2.ndarray( 4, x, 2, 1 );
129121
// returns 5.0
130122
```
131123

@@ -151,22 +143,15 @@ var z = dnrm2.ndarray( N, x, 2, 1 );
151143
<!-- eslint no-undef: "error" -->
152144

153145
```javascript
154-
var randu = require( '@stdlib/random/base/randu' );
155-
var round = require( '@stdlib/math/base/special/round' );
156-
var Float64Array = require( '@stdlib/array/float64' );
146+
var discreteUniform = require( '@stdlib/random/base/discrete-uniform' ).factory;
147+
var filledarrayBy = require( '@stdlib/array/filled-by' );
157148
var dnrm2 = require( '@stdlib/blas/base/dnrm2' );
158149

159-
var x;
160-
var i;
161-
162-
x = new Float64Array( 10 );
163-
for ( i = 0; i < x.length; i++ ) {
164-
x[ i ] = round( randu()*100.0 );
165-
}
150+
var x = filledarrayBy( 10, 'float64', discreteUniform( -100, 100 ) );
166151
console.log( x );
167152

168-
var z = dnrm2( x.length, x, 1 );
169-
console.log( z );
153+
var out = dnrm2( x.length, x, 1 );
154+
console.log( out );
170155
```
171156

172157
</section>

‎lib/node_modules/@stdlib/blas/base/dnrm2/benchmark/benchmark.js‎

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -21,14 +21,19 @@
2121
// MODULES //
2222

2323
var bench = require( '@stdlib/bench' );
24-
var randu = require( '@stdlib/random/base/randu' );
24+
var uniform = require( '@stdlib/random/base/uniform' ).factory;
25+
var filledarrayBy = require( '@stdlib/array/filled-by' );
2526
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2627
var pow = require( '@stdlib/math/base/special/pow' );
27-
var Float64Array = require( '@stdlib/array/float64' );
2828
var pkg = require( './../package.json' ).name;
2929
var dnrm2 = require( './../lib/dnrm2.js' );
3030

3131

32+
// VARIABLES //
33+
34+
var rand = uniform( -100.0, 100.0 );
35+
36+
3237
// FUNCTIONS //
3338

3439
/**
@@ -39,13 +44,7 @@ var dnrm2 = require( './../lib/dnrm2.js' );
3944
* @returns {Function} benchmark function
4045
*/
4146
function createBenchmark( len ) {
42-
var x;
43-
var i;
44-
45-
x = new Float64Array( len );
46-
for ( i = 0; i < x.length; i++ ) {
47-
x[ i ] = ( randu()*20.0 ) - 10.0;
48-
}
47+
var x = filledarrayBy( len, 'float64', rand );
4948
return benchmark;
5049

5150
function benchmark( b ) {

‎lib/node_modules/@stdlib/blas/base/dnrm2/benchmark/benchmark.native.js‎

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,10 @@
2222

2323
var resolve = require( 'path' ).resolve;
2424
var bench = require( '@stdlib/bench' );
25-
var randu = require( '@stdlib/random/base/randu' );
25+
var uniform = require( '@stdlib/random/base/uniform' ).factory;
26+
var filledarrayBy = require( '@stdlib/array/filled-by' );
2627
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2728
var pow = require( '@stdlib/math/base/special/pow' );
28-
var Float64Array = require( '@stdlib/array/float64' );
2929
var tryRequire = require( '@stdlib/utils/try-require' );
3030
var pkg = require( './../package.json' ).name;
3131

@@ -36,6 +36,7 @@ var dnrm2 = tryRequire( resolve( __dirname, './../lib/dnrm2.native.js' ) );
3636
var opts = {
3737
'skip': ( dnrm2 instanceof Error )
3838
};
39+
var rand = uniform( -100.0, 100.0 );
3940

4041

4142
// FUNCTIONS //
@@ -48,13 +49,7 @@ var opts = {
4849
* @returns {Function} benchmark function
4950
*/
5051
function createBenchmark( len ) {
51-
var x;
52-
var i;
53-
54-
x = new Float64Array( len );
55-
for ( i = 0; i < x.length; i++ ) {
56-
x[ i ] = ( randu()*20.0 ) - 10.0;
57-
}
52+
var x = filledarrayBy( len, 'float64', rand );
5853
return benchmark;
5954

6055
function benchmark( b ) {

‎lib/node_modules/@stdlib/blas/base/dnrm2/benchmark/benchmark.ndarray.js‎

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -21,14 +21,19 @@
2121
// MODULES //
2222

2323
var bench = require( '@stdlib/bench' );
24-
var randu = require( '@stdlib/random/base/randu' );
24+
var uniform = require( '@stdlib/random/base/uniform' ).factory;
25+
var filledarrayBy = require( '@stdlib/array/filled-by' );
2526
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2627
var pow = require( '@stdlib/math/base/special/pow' );
27-
var Float64Array = require( '@stdlib/array/float64' );
2828
var pkg = require( './../package.json' ).name;
2929
var dnrm2 = require( './../lib/ndarray.js' );
3030

3131

32+
// VARIABLES //
33+
34+
var rand = uniform( -100.0, 100.0 );
35+
36+
3237
// FUNCTIONS //
3338

3439
/**
@@ -39,13 +44,7 @@ var dnrm2 = require( './../lib/ndarray.js' );
3944
* @returns {Function} benchmark function
4045
*/
4146
function createBenchmark( len ) {
42-
var x;
43-
var i;
44-
45-
x = new Float64Array( len );
46-
for ( i = 0; i < x.length; i++ ) {
47-
x[ i ] = ( randu()*20.0 ) - 10.0;
48-
}
47+
var x = filledarrayBy( len, 'float64', rand );
4948
return benchmark;
5049

5150
function benchmark( b ) {

‎lib/node_modules/@stdlib/blas/base/dnrm2/benchmark/benchmark.ndarray.native.js‎

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,10 @@
2222

2323
var resolve = require( 'path' ).resolve;
2424
var bench = require( '@stdlib/bench' );
25-
var randu = require( '@stdlib/random/base/randu' );
25+
var uniform = require( '@stdlib/random/base/uniform' ).factory;
26+
var filledarrayBy = require( '@stdlib/array/filled-by' );
2627
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2728
var pow = require( '@stdlib/math/base/special/pow' );
28-
var Float64Array = require( '@stdlib/array/float64' );
2929
var tryRequire = require( '@stdlib/utils/try-require' );
3030
var pkg = require( './../package.json' ).name;
3131

@@ -36,6 +36,7 @@ var dnrm2 = tryRequire( resolve( __dirname, './../lib/ndarray.native.js' ) );
3636
var opts = {
3737
'skip': ( dnrm2 instanceof Error )
3838
};
39+
var rand = uniform( -100.0, 100.0 );
3940

4041

4142
// FUNCTIONS //
@@ -48,13 +49,7 @@ var opts = {
4849
* @returns {Function} benchmark function
4950
*/
5051
function createBenchmark( len ) {
51-
var x;
52-
var i;
53-
54-
x = new Float64Array( len );
55-
for ( i = 0; i < x.length; i++ ) {
56-
x[ i ] = ( randu()*20.0 ) - 10.0;
57-
}
52+
var x = filledarrayBy( len, 'float64', rand );
5853
return benchmark;
5954

6055
function benchmark( b ) {

‎lib/node_modules/@stdlib/blas/base/dnrm2/docs/repl.txt‎

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
Indexing is relative to the first index. To introduce an offset, use a typed
99
array view.
1010

11-
If `N <= 0` or `stride <= 0`, the function returns `0.0`.
11+
If `N <= 0` or `stride <= 0`, the function returns `0`.
1212

1313
Parameters
1414
----------
@@ -35,19 +35,16 @@
3535

3636
// Using `N` and `stride` parameters:
3737
> x = new {{alias:@stdlib/array/float64}}( [ -2.0, 1.0, 1.0, -5.0, 2.0, -1.0 ] );
38-
> var N = {{alias:@stdlib/math/base/special/floor}}( x.length / 2 );
39-
> var stride = 2;
40-
> {{alias}}( N, x, stride )
38+
> {{alias}}( 3, x, 2 )
4139
3.0
4240

4341
// Using view offsets:
4442
> var x0 = new {{alias:@stdlib/array/float64}}( [ 1.0, -2.0, 3.0, 2.0, 5.0, -1.0 ] );
4543
> var x1 = new {{alias:@stdlib/array/float64}}( x0.buffer, x0.BYTES_PER_ELEMENT*1 );
46-
> N = {{alias:@stdlib/math/base/special/floor}}( x0.length / 2 );
47-
> stride = 2;
48-
> {{alias}}( N, x1, stride )
44+
> {{alias}}( 3, x1, 2 )
4945
3.0
5046

47+
5148
{{alias}}.ndarray( N, x, stride, offset )
5249
Computes the L2-norm of a double-precision floating-point vector using
5350
alternative indexing semantics.
@@ -84,8 +81,7 @@
8481

8582
// Using offset parameter:
8683
> var x = new {{alias:@stdlib/array/float64}}( [ 1.0, -2.0, 3.0, 2.0, 5.0, -1.0 ] );
87-
> var N = {{alias:@stdlib/math/base/special/floor}}( x.length / 2 );
88-
> {{alias}}.ndarray( N, x, 2, 1 )
84+
> {{alias}}.ndarray( 3, x, 2, 1 )
8985
3.0
9086

9187
See Also

‎lib/node_modules/@stdlib/blas/base/dnrm2/examples/index.js‎

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -18,19 +18,12 @@
1818

1919
'use strict';
2020

21-
var randu = require( '@stdlib/random/base/randu' );
22-
var round = require( '@stdlib/math/base/special/round' );
23-
var Float64Array = require( '@stdlib/array/float64' );
21+
var discreteUniform = require( '@stdlib/random/base/discrete-uniform' ).factory;
22+
var filledarrayBy = require( '@stdlib/array/filled-by' );
2423
var dnrm2 = require( './../lib' );
2524

26-
var x;
27-
var i;
28-
29-
x = new Float64Array( 10 );
30-
for ( i = 0; i < x.length; i++ ) {
31-
x[ i ] = round( randu() * 10.0 );
32-
}
25+
var x = filledarrayBy( 10, 'float64', discreteUniform( -100, 100 ) );
3326
console.log( x );
3427

35-
var z = dnrm2( x.length, x, 1 );
36-
console.log( z );
28+
var out = dnrm2( x.length, x, 1 );
29+
console.log( out );

‎lib/node_modules/@stdlib/blas/base/dnrm2/include.gypi‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@
5252

5353
# Source files:
5454
'src_files': [
55-
'<(src_dir)/addon.cpp',
55+
'<(src_dir)/addon.c',
5656
'<!@(node -e "var arr = require(\'@stdlib/utils/library-manifest\')(\'./manifest.json\',{\'os\':\'<(OS)\',\'blas\':\'<(blas)\'},{\'basedir\':process.cwd(),\'paths\':\'posix\'}).src; for ( var i = 0; i < arr.length; i++ ) { console.log( arr[ i ] ); }")',
5757
],
5858

‎lib/node_modules/@stdlib/blas/base/dnrm2/lib/dnrm2.js‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,15 +33,14 @@ var pow = require( '@stdlib/math/base/special/pow' );
3333
* @param {PositiveInteger} N - number of indexed elements
3434
* @param {Float64Array} x - input array
3535
* @param {PositiveInteger} stride - stride length
36-
* @returns {number} L2-norm of `x`
36+
* @returns {number} L2-norm
3737
*
3838
* @example
3939
* var Float64Array = require( '@stdlib/array/float64' );
4040
*
4141
* var x = new Float64Array( [ 1.0, -2.0, 2.0 ] );
42-
* var N = 3;
4342
*
44-
* var z = dnrm2( N, x, 1 );
43+
* var out = dnrm2( 3, x, 1 );
4544
* // returns 3.0
4645
*/
4746
function dnrm2( N, x, stride ) {

‎lib/node_modules/@stdlib/blas/base/dnrm2/lib/dnrm2.native.js‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,15 +31,14 @@ var addon = require( './../src/addon.node' );
3131
* @param {PositiveInteger} N - number of indexed elements
3232
* @param {Float64Array} x - input array
3333
* @param {PositiveInteger} stride - stride length
34-
* @returns {number} L2-norm of `x`
34+
* @returns {number} L2-norm
3535
*
3636
* @example
3737
* var Float64Array = require( '@stdlib/array/float64' );
3838
*
3939
* var x = new Float64Array( [ 1.0, -2.0, 2.0 ] );
40-
* var N = 3;
4140
*
42-
* var z = dnrm2( N, x, 1 );
41+
* var z = dnrm2( 3, x, 1 );
4342
* // returns 3.0
4443
*/
4544
function dnrm2( N, x, stride ) {

0 commit comments

Comments
 (0)