Refactor to ignore iterator return values

kgryte · kgryte · commit 208a9cce6bd6 · 2021-12-15T21:12:57.000-08:00
diff --git a/lib/node_modules/@stdlib/iter/intersection/lib/main.js b/lib/node_modules/@stdlib/iter/intersection/lib/main.js
@@ -23,7 +23,6 @@
 var setReadOnly = require( '@stdlib/utils/define-nonenumerable-read-only-property' );
 var isFunction = require( '@stdlib/assert/is-function' );
 var isIteratorLike = require( '@stdlib/assert/is-iterator-like' );
-var hasOwnProp = require( '@stdlib/assert/has-own-property' );
 var iteratorSymbol = require( '@stdlib/symbol/iterator' );
 var LinkedList = require( '@stdlib/utils/linked-list' );
 
@@ -91,14 +90,6 @@ function intersection( iterators ) {
 	while ( true ) {
 		v = it.next();
 		if ( v.done ) {
-			if ( hasOwnProp( v, 'value' ) ) {
-				// Determine if we have seen this value before...
-				n = getNode( hash, v.value );
-				if ( n === null ) {
-					// First time we have seen this value, so add to our unique value hash:
-					hash.push( [ v.value, 1 ] );
-				}
-			}
 			break;
 		}
 		// Determine if we have seen this value before...
@@ -118,13 +109,6 @@ function intersection( iterators ) {
 		while ( true ) {
 			v = it.next();
 			if ( v.done ) {
-				if ( hasOwnProp( v, 'value' ) ) {
-					n = getNode( hash, v.value );
-					if ( n && n.value[ 1 ] === j ) {
-						// Only increment a value's counter the first time we see the value per iterator...
-						n.value[ 1 ] += 1;
-					}
-				}
 				break;
 			}
 			n = getNode( hash, v.value );
diff --git a/lib/node_modules/@stdlib/iter/intersection/test/test.js b/lib/node_modules/@stdlib/iter/intersection/test/test.js
@@ -29,37 +29,6 @@ var iterEmpty = require( '@stdlib/iter/empty' );
 var iterIntersection = require( './../lib' );
 
 
-// FUNCTIONS //
-
-function createIterator( arr ) {
-	var len;
-	var it;
-	var i;
-
-	len = arr.length;
-	i = -1;
-
-	it = {};
-	it.next = next;
-
-	return it;
-
-	function next() {
-		var out;
-		i += 1;
-		if ( i < len ) {
-			out = {};
-			out.value = arr[ i ];
-			out.done = ( i === len-1 );
-			return out;
-		}
-		return {
-			'done': true
-		};
-	}
-}
-
-
 // TESTS //
 
 tape( 'main export is a function', function test( t ) {
@@ -380,204 +349,6 @@ tape( 'the function returns an iterator which returns the intersection of three
 	t.end();
 });
 
-tape( 'the function returns an iterator protocol-compliant object (value+done)', function test( t ) {
-	var expected;
-	var values1;
-	var values2;
-	var actual;
-	var it1;
-	var it2;
-	var it;
-	var i;
-
-	values1 = [ 4, 2, 4 ];
-	values2 = [ 1, 3, 4 ];
-	expected = [
-		{
-			'value': 4,
-			'done': false
-		},
-		{
-			'done': true
-		}
-	];
-
-	it1 = createIterator( values1 );
-	it2 = createIterator( values2 );
-
-	it = iterIntersection( it1, it2 );
-	t.equal( it.next.length, 0, 'has zero arity' );
-
-	actual = [];
-	for ( i = 0; i < expected.length; i++ ) {
-		actual.push( it.next() );
-	}
-	t.deepEqual( actual, expected, 'returns expected values' );
-	t.end();
-});
-
-tape( 'the function returns an iterator protocol-compliant object (value+done)', function test( t ) {
-	var expected;
-	var values1;
-	var values2;
-	var actual;
-	var it1;
-	var it2;
-	var it;
-
-	values1 = [ 4, 2 ];
-	values2 = [ 1, 3 ];
-	expected = [
-		{
-			'done': true
-		}
-	];
-
-	it1 = createIterator( values1 );
-	it2 = createIterator( values2 );
-
-	it = iterIntersection( it1, it2 );
-	t.equal( it.next.length, 0, 'has zero arity' );
-
-	actual = [];
-	actual.push( it.next() );
-
-	t.deepEqual( actual, expected, 'returns expected values' );
-	t.end();
-});
-
-tape( 'the function returns an iterator which returns the intersection of two iterators (value+done)', function test( t ) {
-	var expected;
-	var values1;
-	var values2;
-	var actual;
-	var it1;
-	var it2;
-	var it;
-	var i;
-
-	values1 = [ 2, 1, 2, 1, 1, 4 ];
-	values2 = [ 4, 4, 3, 2, 1 ];
-	expected = [
-		{
-			'value': 2,
-			'done': false
-		},
-		{
-			'value': 1,
-			'done': false
-		},
-		{
-			'value': 4,
-			'done': false
-		},
-		{
-			'done': true
-		}
-	];
-
-	it1 = createIterator( values1 );
-	it2 = createIterator( values2 );
-
-	it = iterIntersection( it1, it2 );
-	t.equal( it.next.length, 0, 'has zero arity' );
-
-	actual = [];
-	for ( i = 0; i < expected.length; i++ ) {
-		actual.push( it.next() );
-	}
-	t.deepEqual( actual, expected, 'returns expected values' );
-	t.end();
-});
-
-tape( 'the function returns an iterator which returns the intersection of three iterators (value+done)', function test( t ) {
-	var expected;
-	var values1;
-	var values2;
-	var values3;
-	var actual;
-	var it1;
-	var it2;
-	var it3;
-	var it;
-	var i;
-
-	values1 = [ 2, 1, 2, 1, 1, 4 ];
-	values2 = [ 4, 4, 1, 3, 2 ];
-	values3 = [ 5, 2, 1 ];
-	expected = [
-		{
-			'value': 2,
-			'done': false
-		},
-		{
-			'value': 1,
-			'done': false
-		},
-		{
-			'done': true
-		}
-	];
-
-	it1 = createIterator( values1 );
-	it2 = createIterator( values2 );
-	it3 = createIterator( values3 );
-
-	it = iterIntersection( it1, it2, it3 );
-	t.equal( it.next.length, 0, 'has zero arity' );
-
-	actual = [];
-	for ( i = 0; i < expected.length; i++ ) {
-		actual.push( it.next() );
-	}
-	t.deepEqual( actual, expected, 'returns expected values' );
-	t.end();
-});
-
-tape( 'the function returns an iterator which returns the intersection of two or more iterators (value+done)', function test( t ) {
-	var expected;
-	var values1;
-	var values2;
-	var actual;
-	var it1;
-	var it2;
-	var it;
-	var i;
-
-	values1 = [ 2, 1, 2, 1, 1, 4 ];
-	values2 = [ 4, 4, 3, 2, 1, 5 ];
-	expected = [
-		{
-			'value': 2,
-			'done': false
-		},
-		{
-			'value': 1,
-			'done': false
-		},
-		{
-			'value': 4,
-			'done': false
-		},
-		{
-			'done': true
-		}
-	];
-
-	it1 = createIterator( values1 );
-	it2 = createIterator( values2 );
-
-	it = iterIntersection( it1, it2 );
-	t.equal( it.next.length, 0, 'has zero arity' );
-
-	actual = [];
-	for ( i = 0; i < expected.length; i++ ) {
-		actual.push( it.next() );
-	}
-	t.deepEqual( actual, expected, 'returns expected values' );
-	t.end();
-});
-
 tape( 'the returned iterator has a `return` method for closing an iterator (no argument)', function test( t ) {
 	var rand1;
 	var rand2;
