Skip to content

Commit 14286fa

Browse files
committed
Remove binary and uint8c from list of supported dtypes
The reason being that binary and uint8c require specialized behavior. E.g., uint8c requires logic for handling overflow and underflow--logic which the current strided loops do not include. For binary, not clear to me atm whether the loops are sufficient for handling data in binary format (e.g., strings, etc). Binary data may require specialized loops. Accordingly, these dtypes are removed until we've evaluated requirements. These dtypes are likely less needed than the remaining dtypes, so, until support is demanded, we can exclude them from the list of supported dtypes.
1 parent c44935f commit 14286fa

File tree

4 files changed

+3
-11
lines changed

4 files changed

+3
-11
lines changed

lib/node_modules/@stdlib/strided/dtypes/README.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,12 +46,11 @@ Returns a list of strided array data types.
4646

4747
```javascript
4848
var out = dtypes();
49-
// returns [ 'binary', 'float32', 'float64', 'generic', 'int16', 'int32', 'int8', 'uint16', 'uint32', 'uint8', 'uint8c' ]
49+
// returns [ 'float32', 'float64', 'generic', 'int16', 'int32', 'int8', 'uint16', 'uint32', 'uint8' ]
5050
```
5151

5252
The output `array` contains the following data types:
5353

54-
- `binary`: binary.
5554
- `float32`: single-precision floating-point numbers.
5655
- `float64`: double-precision floating-point numbers.
5756
- `generic`: values of any type.
@@ -61,7 +60,6 @@ The output `array` contains the following data types:
6160
- `uint16`: unsigned 16-bit integers.
6261
- `uint32`: unsigned 32-bit integers.
6362
- `uint8`: unsigned 8-bit integers.
64-
- `uint8c`: unsigned clamped 8-bit integers.
6563

6664
</section>
6765

lib/node_modules/@stdlib/strided/dtypes/docs/repl.txt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44

55
The output array contains the following data types:
66

7-
- binary: binary.
87
- float32: single-precision floating-point numbers.
98
- float64: double-precision floating-point numbers.
109
- generic: values of any type.
@@ -14,7 +13,6 @@
1413
- uint16: unsigned 16-bit integers.
1514
- uint32: unsigned 32-bit integers.
1615
- uint8: unsigned 8-bit integers.
17-
- uint8c: unsigned clamped 8-bit integers.
1816

1917
Returns
2018
-------
Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
[
2-
"binary",
32
"float32",
43
"float64",
54
"generic",
@@ -8,6 +7,5 @@
87
"int8",
98
"uint16",
109
"uint32",
11-
"uint8",
12-
"uint8c"
10+
"uint8"
1311
]

lib/node_modules/@stdlib/strided/dtypes/test/test.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ tape( 'the function returns a list of strided array data types', function test(
3737
var actual;
3838

3939
expected = [
40-
'binary',
4140
'float32',
4241
'float64',
4342
'generic',
@@ -46,8 +45,7 @@ tape( 'the function returns a list of strided array data types', function test(
4645
'int8',
4746
'uint16',
4847
'uint32',
49-
'uint8',
50-
'uint8c'
48+
'uint8'
5149
];
5250
actual = dtypes();
5351

0 commit comments

Comments
 (0)