Fix dereferencing pointer bug

kgryte · kgryte · commit 0cd3c8ad8e39 · 2022-12-24T18:37:25.000-08:00
diff --git a/lib/node_modules/@stdlib/napi/argv-float/lib/native.js b/lib/node_modules/@stdlib/napi/argv-float/lib/native.js
@@ -30,12 +30,14 @@ var addon = require( './../src/addon.node' );
 *
 * @private
 * @param {number} v - input value
+* @returns {number} input value
 *
 * @example
-* wrapper( 1 );
+* var v = wrapper( 1 );
+* // returns 1.0
 */
 function wrapper( v ) {
-	addon( v );
+	return addon( v );
 }
 
 
diff --git a/lib/node_modules/@stdlib/napi/argv-float/src/addon.c b/lib/node_modules/@stdlib/napi/argv-float/src/addon.c
@@ -44,12 +44,13 @@ static napi_value addon( napi_env env, napi_callback_info info ) {
 	STDLIB_NAPI_ARGV( env, info, argv, argc, 1 )
 	STDLIB_NAPI_ARGV_FLOAT( env, value, argv, 0 )
 	float out = identity( value );
-	if ( out != out ) {
-		napi_status status = napi_throw_error( env, NULL, "unexpected error" );
-		assert( status == napi_ok );
+	if ( out == 3.14567890123f ) {
+		assert( napi_throw_error( env, NULL, "unexpected error" ) == napi_ok );
 		return NULL;
 	}
-	return NULL;
+	napi_value v;
+	assert( napi_create_double( env, (double)out, &v ) == napi_ok );
+	return v;
 }
 
 /**
diff --git a/lib/node_modules/@stdlib/napi/argv-float/src/main.c b/lib/node_modules/@stdlib/napi/argv-float/src/main.c
@@ -55,7 +55,7 @@
 napi_status stdlib_napi_argv_float( const napi_env env, const napi_value value, float *out, const char *message, napi_value *err ) {
 	double v;
 	stdlib_assert_napi_value_is_type( env, value, napi_number, message, err );
-	if ( err != NULL ) {
+	if ( *err != NULL ) {
 		return napi_ok;
 	}
 	STDLIB_ASSERT_NAPI_STATUS_OK_RET_VALUE( env, napi_get_value_double( env, value, &v ), "", napi_ok )
diff --git a/lib/node_modules/@stdlib/napi/argv-float/test/test.native.js b/lib/node_modules/@stdlib/napi/argv-float/test/test.native.js
@@ -79,7 +79,11 @@ tape( 'the function does not throw an error if provided a number', opts, functio
 	];
 	for ( i = 0; i < values.length; i++ ) {
 		v = addon( values[ i ] );
-		t.strictEqual( v, void 0, 'returns expected value when provided '+values[ i ] );
+		if ( values[ i ] === values[ i ] ) {
+			t.strictEqual( v, values[ i ], 'returns expected value when provided '+values[ i ] );
+		} else {
+			t.strictEqual( v !== v, true, 'returns expected value when provided '+values[ i ] );
+		}
 	}
 	t.end();
 });

Original file line number	Diff line number	Diff line change
`@@ -30,12 +30,14 @@ var addon = require( './../src/addon.node' );`
`30`	`30`	`*`
`31`	`31`	`* @private`
`32`	`32`	`* @param {number} v - input value`
	`33`	`+* @returns {number} input value`
`33`	`34`	`*`
`34`	`35`	`* @example`
`35`		`-* wrapper( 1 );`
	`36`	`+* var v = wrapper( 1 );`
	`37`	`+* // returns 1.0`
`36`	`38`	`*/`
`37`	`39`	`function wrapper( v ) {`
`38`		`- addon( v );`
	`40`	`+ return addon( v );`
`39`	`41`	`}`
`40`	`42`
`41`	`43`
Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@`
`55`	`55`	`napi_status stdlib_napi_argv_float( const napi_env env, const napi_value value, float out, const char message, napi_value *err ) {`
`56`	`56`	`double v;`
`57`	`57`	`stdlib_assert_napi_value_is_type( env, value, napi_number, message, err );`
`58`		`- if ( err != NULL ) {`
	`58`	`+ if ( *err != NULL ) {`
`59`	`59`	`return napi_ok;`
`60`	`60`	`}`
`61`	`61`	`STDLIB_ASSERT_NAPI_STATUS_OK_RET_VALUE( env, napi_get_value_double( env, value, &v ), "", napi_ok )`