Skip to content

Commit 2a8ee35

Browse files
schlosnavelo
authored andcommitted
JacksonEncoder avoids intermediate String request body (OpenFeign#989)
* JacksonEncoder avoids intermediate String request body Serialize Jackson request object directly to UTF-8 byte array without intermediate String representation. See https://github.com/FasterXML/jackson-docs/wiki/Presentation:-Jackson-Performance#basics-things-you-should-do-anyway * Use Util.UTF_8
1 parent a24580e commit 2a8ee35

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

‎jackson/src/main/java/feign/jackson/JacksonEncoder.java‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
import feign.RequestTemplate;
2525
import feign.codec.EncodeException;
2626
import feign.codec.Encoder;
27+
import feign.Util;
2728

2829
public class JacksonEncoder implements Encoder {
2930

@@ -48,7 +49,7 @@ public JacksonEncoder(ObjectMapper mapper) {
4849
public void encode(Object object, Type bodyType, RequestTemplate template) {
4950
try {
5051
JavaType javaType = mapper.getTypeFactory().constructType(bodyType);
51-
template.body(mapper.writerFor(javaType).writeValueAsString(object));
52+
template.body(mapper.writerFor(javaType).writeValueAsBytes(object), Util.UTF_8);
5253
} catch (JsonProcessingException e) {
5354
throw new EncodeException(e.getMessage(), e);
5455
}

0 commit comments

Comments
 (0)