Skip to content

Commit 966882f

Browse files
authored
Strict boolean support for Strings in and out (graphql-java#2419)
1 parent d5cc61c commit 966882f

2 files changed

Lines changed: 16 additions & 5 deletions

File tree

‎src/main/java/graphql/scalar/GraphqlBooleanCoercing.java‎

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,14 @@ private Boolean convertImpl(Object input) {
2222
if (input instanceof Boolean) {
2323
return (Boolean) input;
2424
} else if (input instanceof String) {
25-
return Boolean.parseBoolean((String) input);
25+
String lStr = ((String) input).toLowerCase();
26+
if (lStr.equals("true")) {
27+
return true;
28+
}
29+
if (lStr.equals("false")) {
30+
return false;
31+
}
32+
return null;
2633
} else if (isNumberIsh(input)) {
2734
BigDecimal value;
2835
try {

‎src/test/groovy/graphql/ScalarsBooleanTest.groovy‎

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,6 @@ class ScalarsBooleanTest extends Specification {
5050
"false" | false
5151
"true" | true
5252
"True" | true
53-
"some value not true" | false
54-
"" | false
5553
0 | false
5654
1 | true
5755
-1 | true
@@ -70,8 +68,14 @@ class ScalarsBooleanTest extends Specification {
7068
thrown(CoercingSerializeException)
7169

7270
where:
73-
value | _
74-
new Object() | _
71+
value | _
72+
new Object() | _
73+
"some value not true" | _
74+
"" | _
75+
"T" | _
76+
"t" | _
77+
"F" | _
78+
"f" | _
7579
}
7680

7781
@Unroll

0 commit comments

Comments
 (0)