feat(install): support arbitrary GitHub repos, refs, and renames - #42
Merged
Conversation
jspod install previously hardcoded github.com/solid-apps/<name>. Accept three input shapes now: jspod install chrome # solid-apps/<name> jspod install <org>/<repo> # any GitHub repo jspod install https://github.com/<org>/<repo> # full URL Optional suffixes apply to any form: ...#<branch-or-tag> pin a ref (uses `git clone --branch <ref>`) ...=<pod-path-name> rename the pod path (e.g. for repos whose name doesn't fit a clean /public/apps/<x>/ slot, like litecut/litecut.github.io=litecut) The pod-path name is derived from the repo's last segment when not overridden. Banner no longer hardcodes "solid-apps" since sources vary. Help and README updated with examples. Fixes #25.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25. Builds on the install subcommand from #40.
What
Three input shapes accepted:
Two optional suffixes apply to any shape:
Verified end-to-end
```
$ jspod install litecut/litecut.github.io=litecut
✓ litecut/litecut.github.io=litecut → http://localhost:5444/public/apps/litecut/
```
Diff
Follow-up
`#24` (non-git sources) stays open as the long-term umbrella.