fix(mcp): use isDirectory not isContainer on listContainer entries - #492
Merged
Conversation
storage.listContainer returns { name, isDirectory, size, modified } —
not isContainer. The MCP skill discovery walks /public/apps/ and
/private/bots/ but the filter was always false, so per-app and per-bot
SKILL.md files were never picked up. list_resources had the same wrong
field for its isContainer output flag.
Live-fire smoke caught it: three SKILL.md files seeded (pod, app, bot)
but only the pod one was returned by list_skills until the field was
fixed.
Added a regression test that asserts isContainer=true on a
list_resources result for a known directory entry — would have failed
on the old code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Live-fire smoke against `jss start --mcp` caught this: three SKILL.md files seeded at the three scope paths (pod / app / bot), but `list_skills` only returned the pod one.
Cause: `storage.listContainer` returns `{ name, isDirectory, size, modified }` — not `isContainer`. The skill-discovery walker filtered on the wrong field, so the always-false filter dropped every per-app and per-bot entry. `list_resources` had the same bug for its `isContainer` output flag.
Fix is one-character per site: `e.isContainer` → `e.isDirectory`. Plus a regression test that asserts `isContainer=true` on a known directory in a `list_resources` result — would have failed on the old code.
Smoke after the fix:
```
list_skills with all three scopes
[
{ "scope": "pod", "name": "pod", "source": "/SKILL.md" },
{ "scope": "app", "name": "demo", "source": "/public/apps/demo/SKILL.md" },
{ "scope": "bot", "name": "charlie", "source": "/private/bots/charlie/SKILL.md" }
]
```
Test plan