Default the auth-required databrowser link to solidos.org/docs/browser/ (#362) - #363
Merged
Merged
Conversation
…r/ (#362) Replaces the hardcoded https://solidos.solidcommunity.net/?uri=... link on the 401 / auth-required page with https://solidos.org/docs/browser/?uri=..., the SolidOS project's GitHub-Pages-hosted browser endpoint. solidos.org/docs/browser/ is hosted by the SolidOS project on stable infrastructure and is independent of any single operator's domain. Closes #362.
There was a problem hiding this comment.
Pull request overview
Updates the 401/auth-required HTML error page to point the “Open in Data Browser” action at the SolidOS project’s GitHub Pages browser endpoint instead of the previously hardcoded solidos.solidcommunity.net URL.
Changes:
- Replace the hardcoded 401 “Open in Data Browser” link target with
https://solidos.org/docs/browser/?uri=....
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| <div class="actions"> | ||
| ${is401 ? `<a href="https://solidos.solidcommunity.net/?uri=${encodeURIComponent(baseUrl + request.url)}" class="btn btn-primary"> | ||
| ${is401 ? `<a href="https://solidos.org/docs/browser/?uri=${encodeURIComponent(baseUrl + request.url)}" class="btn btn-primary"> |
Comment on lines
+365
to
367
| ${is401 ? `<a href="https://solidos.org/docs/browser/?uri=${encodeURIComponent(baseUrl + request.url)}" class="btn btn-primary"> | ||
| Open in Data Browser | ||
| </a>` : ''} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the hardcoded
https://solidos.solidcommunity.net/?uri=...link on the 401 / auth-required page (src/auth/middleware.js:365) withhttps://solidos.org/docs/browser/?uri=..., the SolidOS project's GitHub-Pages-hosted browser endpoint.solidos.org/docs/browser/is hosted by the SolidOS project on stable GitHub Pages infrastructure and is independent of any single operator's domain. Verified live: returns HTTP 200 and honors the?uri=query parameter.Change
One-line URL replacement in
src/auth/middleware.js. No new config, no CLI flag, no scope expansion — just a better default link.Verification
Closes #362.