Summary
JSS bundles src/mashlib-local/ which includes a full mashlib build with its own node_modules/. This couples JSS to mashlib and bloats the distribution.
Why this is wrong
- JSS should not distribute mashlib — it's a separate project
- The
src/mashlib-local/ directory adds significant size and dependencies
- CDN mode (
--mashlib-cdn) and ES module mode (--mashlib-module) already work without any local files
- Users who want local mashlib can install it themselves
Current behavior
src/mashlib-local/ contains a vendored mashlib build with its own node_modules/
--mashlib (local mode) serves from this directory
- This gets published to npm as part of the JSS package
Expected behavior
- Remove
src/mashlib-local/ from the repo and npm package
- Keep
--mashlib-cdn and --mashlib-module as the supported modes
- If local mode is needed, document how to install mashlib separately and point JSS at it via config
- JSS should not be coupled to or distribute mashlib
Summary
JSS bundles
src/mashlib-local/which includes a full mashlib build with its ownnode_modules/. This couples JSS to mashlib and bloats the distribution.Why this is wrong
src/mashlib-local/directory adds significant size and dependencies--mashlib-cdn) and ES module mode (--mashlib-module) already work without any local filesCurrent behavior
src/mashlib-local/contains a vendored mashlib build with its ownnode_modules/--mashlib(local mode) serves from this directoryExpected behavior
src/mashlib-local/from the repo and npm package--mashlib-cdnand--mashlib-moduleas the supported modes