Don't give webview a width if its container has none

mjbvz · mjbvz · commit ea07e9bbdc59 · 2020-04-30T12:24:42.000-07:00
Fixes microsoft#94805 When the panel is maximized over a webview, on reload VS Code calls `.layout` with the dimensions of the editor. However in this case, the dimensions do not match what is actually visible In this case, the parent element should have zero width so we should make sure that we do not try giving the webview a width too
diff --git a/src/vs/workbench/contrib/webview/browser/dynamicWebviewEditorOverlay.ts b/src/vs/workbench/contrib/webview/browser/dynamicWebviewEditorOverlay.ts
@@ -102,8 +102,8 @@ export class DynamicWebviewEditorOverlay extends Disposable implements WebviewOv
 		this.container.style.position = 'absolute';
 		this.container.style.top = `${frameRect.top - containerRect.top}px`;
 		this.container.style.left = `${frameRect.left - containerRect.left}px`;
-		this.container.style.width = `${dimension ? dimension.width : frameRect.width}px`;
-		this.container.style.height = `${dimension ? dimension.height : frameRect.height}px`;
+		this.container.style.width = `${dimension && frameRect.width > 0 ? dimension.width : frameRect.width}px`;
+		this.container.style.height = `${dimension && frameRect.height > 0 ? dimension.height : frameRect.height}px`;
 	}
 
 	private show() {
