Skip to content

Commit 137adf3

Browse files
committed
add an alert system.
1 parent c33eb3e commit 137adf3

File tree

3 files changed

+27
-7
lines changed

3 files changed

+27
-7
lines changed

src/index.html

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -279,7 +279,7 @@
279279
bottom: 0;
280280
width: 400px;
281281
padding: 20px;
282-
z-index: 3;
282+
z-index: 4;
283283
background-color: #111;
284284
transition: 0.3s ease;
285285
will-change: transform;
@@ -404,6 +404,20 @@
404404
visibility: visible;
405405
transform: translateY(0);
406406
}
407+
.alerts-container {
408+
position: fixed;
409+
will-change: transform;
410+
left: 50%;
411+
top: 0;
412+
padding: 10px;
413+
background: #9f3b4e;
414+
border-radius: 3px;
415+
transform: translateY(-100%);
416+
transition: 0.3s ease;
417+
}
418+
.alerts-container.is-active {
419+
transform: translateY(0);
420+
}
407421
</style>
408422
</head>
409423

@@ -607,6 +621,7 @@ <h3>My Items</h3>
607621
</defs>
608622
</svg>
609623

624+
<div class="alerts-container" id="js-alerts-container"></div>
610625
<form style="display:none;" action="http://codepen.io/pen/define" method="POST" target="_blank" id="js-codepen-form">
611626
<input type="hidden" name="data" value='{"title": "New Pen!", "html": "<div>Hello, World!</div>"}'>
612627
</form>
@@ -631,6 +646,7 @@ <h3>My Items</h3>
631646
<script src="utils.js"></script>
632647
<script src="deferred.js"></script>
633648
<script src="loader.js"></script>
649+
<script src="notifications.js"></script>
634650
<script src="script.js"></script>
635651
<script src="dropdown.js"></script>
636652

src/script.js

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@
55
var editur = window.editur || {};
66
var version = '1.7.1';
77

8-
window.$ = document.querySelector.bind(document);
9-
window.$all = document.querySelectorAll.bind(document);
108
window.DEBUG = 1;
119

1210
var HtmlModes = {
@@ -113,11 +111,10 @@
113111
resetSplitting();
114112
}
115113

116-
function saveSetting(setting, value) {
114+
function saveSetting(setting, value, cb) {
117115
var obj = {};
118116
obj[setting] = value;
119-
chrome.storage.local.set(obj, function() {
120-
});
117+
chrome.storage.local.set(obj, cb || function(){});
121118
}
122119

123120
// Save current item to storage
@@ -146,7 +143,9 @@
146143
currentItem.js = editur.cm.js.getValue();
147144
currentItem.updatedOn = Date.now();
148145
utils.log('saving key', key || currentItem.id, currentItem)
149-
saveSetting(key || currentItem.id, currentItem);
146+
saveSetting(key || currentItem.id, currentItem, function () {
147+
alertsService.add('Item saved.');
148+
});
150149
}
151150

152151
function populateItem(items) {
@@ -201,11 +200,13 @@
201200
js: '',
202201
layoutMode: currentLayoutMode
203202
};
203+
alertsService.add('New item created');
204204
refreshEditor();
205205
}
206206
function openItem(itemId) {
207207
currentItem = savedItems[itemId];
208208
refreshEditor();
209+
alertsService.add('Saved item loaded');
209210
}
210211

211212
function refreshEditor() {

src/utils.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
11
(function () {
2+
window.$ = document.querySelector.bind(document);
3+
window.$all = document.querySelectorAll.bind(document);
4+
25
// https://github.com/substack/semver-compare/blob/master/index.js
36
function semverCompare(a, b) {
47
var pa = a.split('.');

0 commit comments

Comments
 (0)