Fix issue where BaseCmdTask was invoking the wrong version of Node.js (microsoft#760)

Nicholas Pape · web-flow · commit fe6eb97a36c8 · 2018-07-25T13:08:57.000-07:00
* Fix an issue in BaseCmdTask.ts where it was using the wrong version of Node.js

* Add changefiles

* Update BaseCmdTask.ts
diff --git a/apps/rush-lib/src/scripts/install-run.ts b/apps/rush-lib/src/scripts/install-run.ts
@@ -125,6 +125,9 @@ export function getNpmPath(): string {
         // We're on Windows
         const whereOutput: string = childProcess.execSync('where npm', { stdio: [] }).toString();
         const lines: string[] = whereOutput.split(os.EOL).filter((line) => !!line);
+
+        // take the last result, we are looking for a .cmd command
+        // see https://github.com/Microsoft/web-build-tools/issues/759
         _npmPath = lines[lines.length - 1];
       } else {
         // We aren't on Windows - assume we're on *NIX or Darwin
diff --git a/common/changes/@microsoft/gulp-core-build-typescript/nickpape-fix-issue-invoking-node_2018-07-24-22-33.json b/common/changes/@microsoft/gulp-core-build-typescript/nickpape-fix-issue-invoking-node_2018-07-24-22-33.json
@@ -0,0 +1,11 @@
+{
+  "changes": [
+    {
+      "packageName": "@microsoft/gulp-core-build-typescript",
+      "comment": "Fix an issue where the TscTask and TslintTasks where invoking the wrong version of Node.js",
+      "type": "patch"
+    }
+  ],
+  "packageName": "@microsoft/gulp-core-build-typescript",
+  "email": "nickpape-msft@users.noreply.github.com"
+}
diff --git a/common/changes/@microsoft/rush/nickpape-fix-issue-invoking-node_2018-07-24-22-33.json b/common/changes/@microsoft/rush/nickpape-fix-issue-invoking-node_2018-07-24-22-33.json
@@ -0,0 +1,11 @@
+{
+  "changes": [
+    {
+      "comment": "",
+      "packageName": "@microsoft/rush",
+      "type": "none"
+    }
+  ],
+  "packageName": "@microsoft/rush",
+  "email": "nickpape-msft@users.noreply.github.com"
+}
diff --git a/core-build/gulp-core-build-typescript/src/miniTasks/BaseCmdTask.ts b/core-build/gulp-core-build-typescript/src/miniTasks/BaseCmdTask.ts
@@ -64,7 +64,9 @@ export abstract class BaseCmdTask<TTaskConfig extends IBaseCmdTaskConfig> extend
           // We're on Windows
           const whereOutput: string = childProcess.execSync('where node', { stdio: [] }).toString();
           const lines: string[] = whereOutput.split(os.EOL).filter((line) => !!line);
-          BaseCmdTask.__nodePath = lines[lines.length - 1];
+
+          // take the first result, see https://github.com/Microsoft/web-build-tools/issues/759
+          BaseCmdTask.__nodePath = lines[0];
         } else {
           // We aren't on Windows - assume we're on *NIX or Darwin
           BaseCmdTask.__nodePath = childProcess.execSync('which node', { stdio: [] }).toString();
