More feedback addressed

Vitalius1 · Vitalius1 · commit de5a492046fe · 2019-05-16T00:13:53.000-07:00
diff --git a/apps/api-documenter/src/cli/GenerateAction.ts b/apps/api-documenter/src/cli/GenerateAction.ts
@@ -6,7 +6,7 @@ import * as path from 'path';
 import { ApiDocumenterCommandLine } from './ApiDocumenterCommandLine';
 import { BaseAction } from './BaseAction';
 import { DocumenterConfig } from '../documenters/DocumenterConfig';
-import { ExperimentYamlDocumenter } from '../documenters/ExperimentYamlDocumenter';
+import { ExperimentalYamlDocumenter } from '../documenters/ExperimentalYamlDocumenter';
 import { IConfigFile } from '../documenters/IConfigFile';
 
 import { ApiModel } from '@microsoft/api-extractor-model';
@@ -40,7 +40,7 @@ export class GenerateAction extends BaseAction {
 
     const apiModel: ApiModel = this.buildApiModel();
 
-    const yamlDocumenter: ExperimentYamlDocumenter = new ExperimentYamlDocumenter(apiModel, configFile);
+    const yamlDocumenter: ExperimentalYamlDocumenter = new ExperimentalYamlDocumenter(apiModel, configFile);
     yamlDocumenter.generateFiles(this.outputFolder);
     return Promise.resolve();
   }
diff --git a/apps/api-documenter/src/documenters/DocumenterConfig.ts b/apps/api-documenter/src/documenters/DocumenterConfig.ts
@@ -15,7 +15,7 @@ export class DocumenterConfig {
    * The JSON Schema for API Extractor config file (api-extractor.schema.json).
    */
   public static readonly jsonSchema: JsonSchema = JsonSchema.fromFile(
-    path.join(__dirname, '../schemas/api-documenter.schema.json'));
+    path.join(__dirname, '..', 'schemas', 'api-documenter.schema.json'));
 
   /**
    * The config file name "api-extractor.json".
diff --git a/apps/api-documenter/src/documenters/ExperimentalYamlDocumenter.ts b/apps/api-documenter/src/documenters/ExperimentalYamlDocumenter.ts
@@ -13,7 +13,7 @@ import { YamlDocumenter } from './YamlDocumenter';
  * EXPERIMENTAL - This documenter is a prototype of a new config file driven mode of operation for
  * API Documenter.  It is not ready for general usage yet.  Its design may change in the future.
  */
-export class ExperimentYamlDocumenter extends YamlDocumenter {
+export class ExperimentalYamlDocumenter extends YamlDocumenter {
   private _config: IConfigTableOfContents;
   private _tocPointerMap: { [key: string]: IYamlTocItem };
   private _catchAllPointer: IYamlTocItem;
@@ -22,7 +22,7 @@ export class ExperimentYamlDocumenter extends YamlDocumenter {
     super(apiModel);
     this._config = configFile.tableOfContents!;
 
-    this._tocPointerMap = {}; // need a type?
+    this._tocPointerMap = {};
 
     this._generateTocPointersMap(this._config.tocConfig);
   }
diff --git a/build-tests/api-documenter-test/etc/markdown/api-documenter-test.docbaseclass.md b/build-tests/api-documenter-test/etc/markdown/api-documenter-test.docbaseclass.md
@@ -6,9 +6,8 @@
 
 Example base class
 
-
 <b>Signature:</b>
 
 ```typescript
-export declare class DocBaseClass 
+export declare class DocBaseClass
 ```
diff --git a/common/changes/@microsoft/api-documenter/FabricDocumenter_2019-05-06-23-48.json b/common/changes/@microsoft/api-documenter/FabricDocumenter_2019-05-06-23-48.json
@@ -2,7 +2,7 @@
   "changes": [
     {
       "packageName": "@microsoft/api-documenter",
-      "comment": "Adds optional config file `api-documenter.json` to allow building custom TOC for YamlDocumenter.",
+      "comment": "Add optional config file `api-documenter.json` to allow building custom Table of Contents for YamlDocumenter.",
       "type": "minor"
     }
   ],

Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,7 @@`
`2`	`2`	`"changes": [`
`3`	`3`	`{`
`4`	`4`	`"packageName": "@microsoft/api-documenter",`
`5`		- "comment": "Adds optional config file `api-documenter.json` to allow building custom TOC for YamlDocumenter.",
	`5`	+ "comment": "Add optional config file `api-documenter.json` to allow building custom Table of Contents for YamlDocumenter.",
`6`	`6`	`"type": "minor"`
`7`	`7`	`}`
`8`	`8`	`],`