Include HTML webpack plugin to make the localization plugin test runnable in a browser.

iclanton · iclanton · commit c8b7233f1817 · 2020-02-01T15:02:39.000-08:00
diff --git a/build-tests/localization-plugin-test/package.json b/build-tests/localization-plugin-test/package.json
@@ -17,6 +17,7 @@
     "webpack": "~4.31.0",
     "webpack-bundle-analyzer": "~3.6.0",
     "webpack-cli": "~3.3.2",
-    "webpack-dev-server": "~3.9.0"
+    "webpack-dev-server": "~3.9.0",
+    "html-webpack-plugin": "~3.2.0"
   }
 }
diff --git a/build-tests/localization-plugin-test/webpack.config.js b/build-tests/localization-plugin-test/webpack.config.js
@@ -6,6 +6,7 @@ const webpack = require('webpack');
 const { LocalizationPlugin } = require('@rushstack/localization-plugin');
 const { SetPublicPathPlugin } = require('@microsoft/set-webpack-public-path-plugin');
 const { BundleAnalyzerPlugin } = require('webpack-bundle-analyzer');
+const HtmlWebpackPlugin = require('html-webpack-plugin');
 
 module.exports = function(env) {
   const configuration = {
@@ -105,7 +106,8 @@ module.exports = function(env) {
           name: '[name]_[locale]_[contenthash].js',
           isTokenized: true
         }
-      })
+      }),
+      new HtmlWebpackPlugin()
     ]
   };
 
diff --git a/common/config/rush/nonbrowser-approved-packages.json b/common/config/rush/nonbrowser-approved-packages.json
@@ -390,6 +390,10 @@
       "name": "gulp-typescript",
       "allowedCategories": [ "libraries" ]
     },
+    {
+      "name": "html-webpack-plugin",
+      "allowedCategories": [ "tests" ]
+    },
     {
       "name": "https-proxy-agent",
       "allowedCategories": [ "libraries" ]
diff --git a/common/config/rush/pnpm-lock.yaml b/common/config/rush/pnpm-lock.yaml

Original file line number	Diff line number	Diff line change
`@@ -17,6 +17,7 @@`
`17`	`17`	`"webpack": "~4.31.0",`
`18`	`18`	`"webpack-bundle-analyzer": "~3.6.0",`
`19`	`19`	`"webpack-cli": "~3.3.2",`
`20`		`- "webpack-dev-server": "~3.9.0"`
	`20`	`+ "webpack-dev-server": "~3.9.0",`
	`21`	`+ "html-webpack-plugin": "~3.2.0"`
`21`	`22`	`}`
`22`	`23`	`}`