Merge pull request microsoft#1674 from karanbirsingh/notype

octogonz · web-flow · commit c7303430e964 · 2020-01-09T18:59:27.000-08:00
[load-themed-styles] removing text/css type from style element
diff --git a/common/changes/@microsoft/load-themed-styles/notype_2020-01-07-01-47.json b/common/changes/@microsoft/load-themed-styles/notype_2020-01-07-01-47.json
@@ -0,0 +1,11 @@
+{
+  "changes": [
+    {
+      "packageName": "@microsoft/load-themed-styles",
+      "comment": "Removed type attribute from style tags to align with WHATWG HTML guidelines",
+      "type": "patch"
+    }
+  ],
+  "packageName": "@microsoft/load-themed-styles",
+  "email": "karansin@microsoft.com"
+}
diff --git a/libraries/load-themed-styles/src/index.ts b/libraries/load-themed-styles/src/index.ts
@@ -395,7 +395,6 @@ function registerStyles(styleArray: ThemableArray): void {
   } = resolveThemableArray(styleArray);
 
   styleElement.setAttribute('data-load-themed-styles', 'true');
-  styleElement.type = 'text/css';
   if (_styleNonce) {
     styleElement.setAttribute('nonce', _styleNonce);
   }

Original file line number	Diff line number	Diff line change
`@@ -395,7 +395,6 @@ function registerStyles(styleArray: ThemableArray): void {`
`395`	`395`	`} = resolveThemableArray(styleArray);`
`396`	`396`
`397`	`397`	`styleElement.setAttribute('data-load-themed-styles', 'true');`
`398`		`- styleElement.type = 'text/css';`
`399`	`398`	`if (_styleNonce) {`
`400`	`399`	`styleElement.setAttribute('nonce', _styleNonce);`
`401`	`400`	`}`