Skip to content

Commit c30d36f

Browse files
author
nickpape-msft
authored
Nickpape/fix declaration (microsoft#77)
* Apparently all references for loadSchema must be public, otherwise TS complains * Changefile
1 parent b5c810c commit c30d36f

5 files changed

Lines changed: 29 additions & 4 deletions

File tree

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
{
2+
"changes": [
3+
{
4+
"packageName": "@microsoft/gulp-core-build-webpack",
5+
"comment": "Make loadSchema public instead of protected.",
6+
"type": "patch"
7+
},
8+
{
9+
"packageName": "@microsoft/gulp-core-build-typescript",
10+
"comment": "Make loadSchema public instead of protected.",
11+
"type": "patch"
12+
},
13+
{
14+
"packageName": "@microsoft/gulp-core-build-serve",
15+
"comment": "Make loadSchema public instead of protected.",
16+
"type": "patch"
17+
},
18+
{
19+
"packageName": "@microsoft/gulp-core-build-sass",
20+
"comment": "Make loadSchema public instead of protected.",
21+
"type": "patch"
22+
}
23+
],
24+
"email": "nickpape-msft@users.noreply.github.com"
25+
}

gulp-core-build-sass/src/SassTask.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ export class SassTask extends GulpTask<ISassTaskConfig> {
5656
'src/**/*.scss.ts'
5757
];
5858

59-
protected loadSchema(): Object {
59+
public loadSchema(): Object {
6060
return require('./sass.schema.json');
6161
}
6262

gulp-core-build-serve/src/ServeTask.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ export class ServeTask extends GulpTask<IServeTaskConfig> {
8484
tryCreateDevCertificate: false
8585
};
8686

87-
protected loadSchema(): Object {
87+
public loadSchema(): Object {
8888
return require('./serve.schema.json');
8989
}
9090

gulp-core-build-typescript/src/TypeScriptTask.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ export class TypeScriptTask extends GulpTask<ITypeScriptTaskConfig> {
114114
private _tsProject: ts.Project;
115115
private _tsAMDProject: ts.Project;
116116

117-
protected loadSchema(): Object {
117+
public loadSchema(): Object {
118118
return require('./schemas/typescript.schema.json');
119119
}
120120

gulp-core-build-webpack/src/WebpackTask.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ export class WebpackTask extends GulpTask<IWebpackTaskConfig> {
5252
);
5353
}
5454

55-
protected loadSchema(): Object {
55+
public loadSchema(): Object {
5656
return require('./webpack.schema.json');
5757
}
5858

0 commit comments

Comments
 (0)