Improve the safety around unefined exit codes.

iclanton · iclanton · commit b1783e02f460 · 2020-01-16T21:44:15.000-08:00
diff --git a/apps/rush-lib/src/cli/RushCommandLineParser.ts b/apps/rush-lib/src/cli/RushCommandLineParser.ts
@@ -355,7 +355,7 @@ export class RushCommandLineParser extends CommandLineParser {
     // performs nontrivial work that can throw an exception.  Either the Rush class would need
     // to handle reporting for those exceptions, or else _populateActions() should be moved
     // to a RushCommandLineParser lifecycle stage that can handle it.
-    if (process.exitCode! > 0) {
+    if (!process.exitCode || process.exitCode > 0) {
       process.exit(process.exitCode);
     } else {
       process.exit(1);
diff --git a/apps/rush-lib/src/scripts/install-run.ts b/apps/rush-lib/src/scripts/install-run.ts
@@ -433,7 +433,11 @@ export function installAndRun(
     }
   );
 
-  return result.status || 1; // If result.status is null, the process was terminated from a signal
+  if (result.status) {
+    return result.status;
+  } else {
+    throw result.error || new Error('An unknown error occurred.');
+  }
 }
 
 export function runWithErrorAndStatusCode(fn: () => number): void {

Original file line number	Diff line number	Diff line change
`@@ -433,7 +433,11 @@ export function installAndRun(`
`433`	`433`	`}`
`434`	`434`	`);`
`435`	`435`
`436`		`- return result.status \|\| 1; // If result.status is null, the process was terminated from a signal`
	`436`	`+ if (result.status) {`
	`437`	`+ return result.status;`
	`438`	`+ } else {`
	`439`	`+ throw result.error \|\| new Error('An unknown error occurred.');`
	`440`	`+ }`
`437`	`441`	`}`
`438`	`442`
`439`	`443`	`export function runWithErrorAndStatusCode(fn: () => number): void {`