Report an error if associatedCommands refers to a command that does not exist

pgonzal · pgonzal · commit ab14e03db8a7 · 2018-06-07T18:17:18.000-07:00
diff --git a/apps/rush-lib/src/cli/actions/CustomCommandFactory.ts b/apps/rush-lib/src/cli/actions/CustomCommandFactory.ts
@@ -85,5 +85,15 @@ export class CustomCommandFactory {
             + ` using an unsupported command kind "${command!.commandKind}"`);
       }
     }
+
+    // Check for any invalid associations
+    for (const parameter of commandLineConfiguration.parameters) {
+      for (const associatedCommand of parameter.associatedCommands) {
+        if (!parser.tryGetAction(associatedCommand)) {
+          throw new Error(`${RushConstants.commandLineFilename} defines a parameter "${parameter.longName}"`
+            + ` that is associated with a nonexistent command "${associatedCommand}"`);
+        }
+      }
+    }
   }
 }
diff --git a/apps/rush-lib/src/cli/actions/test/repo/common/config/rush/command-line.json b/apps/rush-lib/src/cli/actions/test/repo/common/config/rush/command-line.json
@@ -55,7 +55,7 @@
       "shortName": "-m",
       "parameterKind": "flag",
       "description": "Perform a fast build, which disables certain tasks such as unit tests and linting",
-      "associatedCommands": [ "build", "rebuild", "deploy" ]
+      "associatedCommands": [ "build", "rebuild" ]
     }
   ]
 }

Original file line number	Diff line number	Diff line change
`@@ -85,5 +85,15 @@ export class CustomCommandFactory {`
`85`	`85`	+ ` using an unsupported command kind "${command!.commandKind}"`);
`86`	`86`	`}`
`87`	`87`	`}`
	`88`	`+`
	`89`	`+ // Check for any invalid associations`
	`90`	`+ for (const parameter of commandLineConfiguration.parameters) {`
	`91`	`+ for (const associatedCommand of parameter.associatedCommands) {`
	`92`	`+ if (!parser.tryGetAction(associatedCommand)) {`
	`93`	+ throw new Error(`${RushConstants.commandLineFilename} defines a parameter "${parameter.longName}"`
	`94`	+ + ` that is associated with a nonexistent command "${associatedCommand}"`);
	`95`	`+ }`
	`96`	`+ }`
	`97`	`+ }`
`88`	`98`	`}`
`89`	`99`	`}`
Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@`
`55`	`55`	`"shortName": "-m",`
`56`	`56`	`"parameterKind": "flag",`
`57`	`57`	`"description": "Perform a fast build, which disables certain tasks such as unit tests and linting",`
`58`		`- "associatedCommands": [ "build", "rebuild", "deploy" ]`
	`58`	`+ "associatedCommands": [ "build", "rebuild" ]`
`59`	`59`	`}`
`60`	`60`	`]`
`61`	`61`	`}`