Fix the floating promises in this project.

lijunle · lijunle · commit 885db0256084 · 2018-12-05T01:58:14.000-08:00
diff --git a/apps/api-documenter/src/start.ts b/apps/api-documenter/src/start.ts
@@ -15,4 +15,4 @@ console.log(os.EOL + colors.bold(`api-documenter ${myPackageVersion} `
 
 const parser: ApiDocumenterCommandLine = new ApiDocumenterCommandLine();
 
-parser.execute();
+parser.execute().catch(console.error);
diff --git a/apps/rush-lib/src/api/Rush.ts b/apps/rush-lib/src/api/Rush.ts
@@ -36,7 +36,7 @@ export class Rush {
     }
 
     const parser: RushCommandLineParser = new RushCommandLineParser();
-    parser.execute();
+    parser.execute().catch(console.error);
   }
 
   /**
diff --git a/apps/rush-lib/src/cli/actions/ChangeAction.ts b/apps/rush-lib/src/cli/actions/ChangeAction.ts
@@ -451,7 +451,7 @@ export class ChangeAction extends BaseRushAction {
           console.log(`Not overwriting ${filePath}...`);
           return Promise.resolve();
         }
-      });
+      }).catch(console.error);
     }
 
     this._writeFile(filePath, output);
diff --git a/core-build/gulp-core-build/src/index.ts b/core-build/gulp-core-build/src/index.ts
@@ -268,7 +268,7 @@ export function watch(watchMatch: string | string[], taskExecutable: IExecutable
         setWatchMode();
         buildConfig.gulp.watch(watchMatch, _runWatch);
 
-        _runWatch();
+        _runWatch().catch(console.error);
       });
     }
   };
diff --git a/core-build/gulp-core-build/src/tasks/BuildReceiptTask.ts b/core-build/gulp-core-build/src/tasks/BuildReceiptTask.ts
@@ -35,21 +35,25 @@ export class CheckBuildReceiptTask extends GulpTask<IBuildReceiptTask> {
     gulp: typeof Gulp,
     completeCallback: (error?: string | Error) => void
   ): Promise<Object> | NodeJS.ReadWriteStream | void {
-    _getLocalHashes().then(localHashes => {
-      _lastLocalHashes = localHashes;
-      _readPackageHashes(path.join(process.cwd(), this.buildConfig.packageFolder, 'build.json')).then(packageHashes => {
-        if (packageHashes) {
-          if (_areObjectsEqual(localHashes, packageHashes)) {
-            this.buildConfig.isRedundantBuild = true;
-            this.log('Build is redundant. Skipping steps.');
-          } else {
-            _areObjectsEqual(localHashes, packageHashes);
-            this.log('Build has new content, continuing execution.');
-          }
-        }
-        completeCallback();
-      });
-    });
+    _getLocalHashes()
+      .then(localHashes => {
+        _lastLocalHashes = localHashes;
+        _readPackageHashes(path.join(process.cwd(), this.buildConfig.packageFolder, 'build.json'))
+          .then(packageHashes => {
+            if (packageHashes) {
+              if (_areObjectsEqual(localHashes, packageHashes)) {
+                this.buildConfig.isRedundantBuild = true;
+                this.log('Build is redundant. Skipping steps.');
+              } else {
+                _areObjectsEqual(localHashes, packageHashes);
+                this.log('Build has new content, continuing execution.');
+              }
+            }
+            completeCallback();
+          })
+          .catch(console.error);
+      })
+      .catch(console.error);
   }
 }
 
diff --git a/stack/rush-stack/src/start.ts b/stack/rush-stack/src/start.ts
@@ -16,4 +16,4 @@ console.log(os.EOL + colors.bold(`rush-stack ${currentPackageVersion} `
 
 const parser: RushStackCommandLine = new RushStackCommandLine();
 
-parser.execute();
+parser.execute().catch(console.error);

Original file line number	Diff line number	Diff line change
@@ -15,4 +15,4 @@ console.log(os.EOL + colors.bold(`api-documenter ${myPackageVersion} `
`15`	`15`
`16`	`16`	`const parser: ApiDocumenterCommandLine = new ApiDocumenterCommandLine();`
`17`	`17`
`18`		`-parser.execute();`
	`18`	`+parser.execute().catch(console.error);`
Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ export class Rush {`
`36`	`36`	`}`
`37`	`37`
`38`	`38`	`const parser: RushCommandLineParser = new RushCommandLineParser();`
`39`		`- parser.execute();`
	`39`	`+ parser.execute().catch(console.error);`
`40`	`40`	`}`
`41`	`41`
`42`	`42`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -451,7 +451,7 @@ export class ChangeAction extends BaseRushAction {`
`451`	`451`	console.log(`Not overwriting ${filePath}...`);
`452`	`452`	`return Promise.resolve();`
`453`	`453`	`}`
`454`		`- });`
	`454`	`+ }).catch(console.error);`
`455`	`455`	`}`
`456`	`456`
`457`	`457`	`this._writeFile(filePath, output);`
Original file line number	Diff line number	Diff line change
`@@ -268,7 +268,7 @@ export function watch(watchMatch: string \| string[], taskExecutable: IExecutable`
`268`	`268`	`setWatchMode();`
`269`	`269`	`buildConfig.gulp.watch(watchMatch, _runWatch);`
`270`	`270`
`271`		`- _runWatch();`
	`271`	`+ _runWatch().catch(console.error);`
`272`	`272`	`});`
`273`	`273`	`}`
`274`	`274`	`};`
Original file line number	Diff line number	Diff line change
@@ -16,4 +16,4 @@ console.log(os.EOL + colors.bold(`rush-stack ${currentPackageVersion} `
`16`	`16`
`17`	`17`	`const parser: RushStackCommandLine = new RushStackCommandLine();`
`18`	`18`
`19`		`-parser.execute();`
	`19`	`+parser.execute().catch(console.error);`