Skip to content

Commit 87bf20f

Browse files
author
nickpape-msft
authored
Merge pull request microsoft#87 from Microsoft/nickpape/update-node-notifier
Bump node-notifier and use @types
2 parents 9d96bd6 + 50375a0 commit 87bf20f

8 files changed

Lines changed: 38 additions & 21 deletions

File tree

‎common/changes/nickpape-update-node-notifier_2017-02-06-23-15.json‎

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
{
2+
"changes": [
3+
{
4+
"packageName": "@microsoft/web-library-build",
5+
"comment": "Remove unused dependency",
6+
"type": "patch"
7+
},
8+
{
9+
"packageName": "@microsoft/gulp-core-build",
10+
"comment": "Update node-notifier to remove SNYK warning about marked package having a vulnerability (although this vulnerability should not affect us)",
11+
"type": "patch"
12+
}
13+
],
14+
"email": "nickpape-msft@users.noreply.github.com"
15+
}

‎common/npm-shrinkwrap.json‎

Lines changed: 14 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎common/temp_modules/rush-gulp-core-build-typescript/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,6 @@
3737
},
3838
"rushDependencies": {
3939
"@microsoft/gulp-core-build": ">=2.1.1 <3.0.0",
40-
"@microsoft/api-extractor": ">=1.1.4 <2.0.0"
40+
"@microsoft/api-extractor": ">=1.1.8 <2.0.0"
4141
}
4242
}

‎common/temp_modules/rush-gulp-core-build/package.json‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,8 @@
3333
"jju": "~1.3.0",
3434
"lodash.merge": "~4.3.2",
3535
"merge2": "~1.0.2",
36-
"node-notifier": "~4.5.0",
36+
"node-notifier": "~5.0.2",
37+
"@types/node-notifier": "0.0.28",
3738
"object-assign": "~4.1.0",
3839
"pretty-hrtime": "~1.0.2",
3940
"rimraf": "~2.5.4",

‎common/temp_modules/rush-web-library-build/package.json‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,14 @@
88
"@types/gulp": "^3.8.32",
99
"@types/node": "^6.0.46",
1010
"gulp": "~3.9.1",
11-
"gulp-replace": "^0.5.4",
12-
"node-notifier": "~4.6.1"
11+
"gulp-replace": "^0.5.4"
1312
},
1413
"optionalDependencies": {
1514
"fsevents": "*"
1615
},
1716
"rushDependencies": {
1817
"@microsoft/gulp-core-build": ">=2.1.1 <3.0.0",
19-
"@microsoft/gulp-core-build-karma": ">=2.1.2 <3.0.0",
18+
"@microsoft/gulp-core-build-karma": ">=2.1.3 <3.0.0",
2019
"@microsoft/gulp-core-build-sass": ">=2.0.3 <3.0.0",
2120
"@microsoft/gulp-core-build-serve": ">=2.0.3 <3.0.0",
2221
"@microsoft/gulp-core-build-typescript": ">=2.2.5 <3.0.0",

‎gulp-core-build/package.json‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,8 @@
4242
"jju": "~1.3.0",
4343
"lodash.merge": "~4.3.2",
4444
"merge2": "~1.0.2",
45-
"node-notifier": "~4.5.0",
45+
"node-notifier": "~5.0.2",
46+
"@types/node-notifier": "0.0.28",
4647
"object-assign": "~4.1.0",
4748
"pretty-hrtime": "~1.0.2",
4849
"rimraf": "~2.5.4",

‎gulp-core-build/src/index.ts‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ export { IExecutable } from './IExecutable';
1414
import { initialize as initializeLogging, markTaskCreationTime, generateGulpError, setWatchMode } from './logging';
1515
import { getFlagValue, setConfigDefaults } from './config';
1616
import * as gulp from 'gulp';
17+
import * as notifier from 'node-notifier';
1718

1819
export * from './IBuildConfig';
1920
export {
@@ -172,10 +173,6 @@ export function subTask(taskName: string, fn: ICustomGulpTask): IExecutable {
172173
* @returns IExecutable
173174
*/
174175
export function watch(watchMatch: string | string[], task: IExecutable): IExecutable {
175-
/* tslint:disable:typedef */
176-
const notifier = require('node-notifier');
177-
/* tslint:enable:typedef */
178-
179176
_trackTask(task);
180177

181178
let isWatchRunning: boolean = false;

‎web-library-build/package.json‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,7 @@
2727
"@types/gulp": "^3.8.32",
2828
"@types/node": "^6.0.46",
2929
"gulp": "~3.9.1",
30-
"gulp-replace": "^0.5.4",
31-
"node-notifier": "~4.6.1"
30+
"gulp-replace": "^0.5.4"
3231
},
3332
"devDependencies": {
3433
"typescript": "~2.1.4"

0 commit comments

Comments
 (0)