Skip to content

Commit 7c70c0b

Browse files
author
nickpape-msft
committed
Changes
1 parent f33dbb0 commit 7c70c0b

4 files changed

Lines changed: 18 additions & 3 deletions

File tree

‎common/reviews/api/api-extractor.api.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ class ApiJsonGenerator extends ApiItemVisitor {
4949
}
5050

5151
class ExternalApiHelper {
52-
// (undocumented)
5352
public static generateApiJson(rootDir: string, libFolder: string, externalPackageFilePath: string): void;
5453
}
5554

‎common/reviews/api/gulp-core-build.api.ts‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,7 @@ class GulpTask<TASK_CONFIG> implements IExecutable {
6868
// (undocumented)
6969
interface IBuildConfig {
7070
args?: {
71+
// (undocumented)
7172
[ name: string ]: string | boolean
7273
}
7374
buildErrorIconPath?: string;
@@ -82,6 +83,7 @@ interface IBuildConfig {
8283
packageFolder?: string;
8384
production?: boolean;
8485
properties?: {
86+
// (undocumented)
8587
[ key: string ]: any
8688
}
8789
relogIssues?: boolean;
@@ -96,6 +98,7 @@ interface IBuildConfig {
9698

9799
interface ICopyConfig {
98100
copyTo: {
101+
// (undocumented)
99102
[ destPath: string ]: string[];
100103
}
101104
shouldFlatten?: boolean;

‎node-library-build/src/index.ts‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { task, watch, serial, parallel, IExecutable } from '@microsoft/gulp-core-build';
1+
import { task, watch, serial, parallel, IExecutable, setConfig } from '@microsoft/gulp-core-build';
22
import { typescript, tslint, apiExtractor } from '@microsoft/gulp-core-build-typescript';
33
import { instrument, mocha } from '@microsoft/gulp-core-build-mocha';
44

@@ -9,6 +9,11 @@ export * from '@microsoft/gulp-core-build-mocha';
99
// Define default task groups.
1010
const buildSubtask: IExecutable = serial(parallel(tslint, typescript), apiExtractor);
1111

12+
const PRODUCTION = process.argv.indexOf('--production') !== -1 || process.argv.indexOf('--ship') !== -1;
13+
setConfig({
14+
shouldWarningsFailBuild: PRODUCTION
15+
});
16+
1217
export const buildTasks: IExecutable = task('build', buildSubtask);
1318
export const testTasks: IExecutable = task('test', serial(buildSubtask, mocha));
1419
export const defaultTasks: IExecutable = task('default', serial(buildSubtask, instrument, mocha));

‎web-library-build/src/index.ts‎

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,9 @@ import {
66
parallel,
77
serial,
88
task,
9-
watch
9+
watch,
10+
setConfig,
11+
1012
} from '@microsoft/gulp-core-build';
1113
import { apiExtractor, typescript, tslint, text } from '@microsoft/gulp-core-build-typescript';
1214
import { sass } from '@microsoft/gulp-core-build-sass';
@@ -34,6 +36,12 @@ const sourceMatch: string[] = [
3436
'!src/**/*.scss.ts'
3537
];
3638

39+
40+
const PRODUCTION = process.argv.indexOf('--production') !== -1 || process.argv.indexOf('--ship') !== -1;
41+
setConfig({
42+
shouldWarningsFailBuild: PRODUCTION
43+
});
44+
3745
// Define default task groups.
3846
export const compileTsTasks: IExecutable = parallel(typescript, text, apiExtractor);
3947
export const buildTasks: IExecutable = task('build', serial(preCopy, sass, compileTsTasks, postCopy));

0 commit comments

Comments
 (0)