Skip to content

Commit 7744051

Browse files
iclantoniclanton
committed
Allowing partial build configs to be passed into the set BuildConfig functions.
1 parent 421a026 commit 7744051

File tree

7 files changed

+12
-12
lines changed

7 files changed

+12
-12
lines changed

‎common/reviews/api/gulp-core-build.api.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ export function log(...args: Array<string | Chalk.ChalkChain>): void;
146146
export function logSummary(value: string): void;
147147

148148
// @public
149-
export function mergeConfig(config: IBuildConfig): void;
149+
export function mergeConfig(config: Partial<IBuildConfig>): void;
150150

151151
// @public
152152
export function parallel(...tasks: Array<IExecutable[] | IExecutable>): IExecutable;
@@ -169,7 +169,7 @@ class SchemaValidator {
169169
export function serial(...tasks: Array<IExecutable[] | IExecutable>): IExecutable;
170170

171171
// @public
172-
export function setConfig(config: IBuildConfig): void;
172+
export function setConfig(config: Partial<IBuildConfig>): void;
173173

174174
// @public
175175
export function subTask(taskName: string, fn: ICustomGulpTask): IExecutable;

‎common/reviews/api/node-library-build.api.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ export declare function log(...args: Array<string | Chalk.ChalkChain>): void;
158158
export declare function logSummary(value: string): void;
159159

160160
// @public
161-
export declare function mergeConfig(config: IBuildConfig): void;
161+
export declare function mergeConfig(config: Partial<IBuildConfig>): void;
162162

163163
// @public
164164
export declare function parallel(...tasks: Array<IExecutable[] | IExecutable>): IExecutable;
@@ -181,7 +181,7 @@ class SchemaValidator {
181181
export declare function serial(...tasks: Array<IExecutable[] | IExecutable>): IExecutable;
182182

183183
// @public
184-
export declare function setConfig(config: IBuildConfig): void;
184+
export declare function setConfig(config: Partial<IBuildConfig>): void;
185185

186186
// @public
187187
export declare function subTask(taskName: string, fn: ICustomGulpTask): IExecutable;

‎common/reviews/api/web-library-build.api.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ export declare function log(...args: Array<string | Chalk.ChalkChain>): void;
166166
export declare function logSummary(value: string): void;
167167

168168
// @public
169-
export declare function mergeConfig(config: IBuildConfig): void;
169+
export declare function mergeConfig(config: Partial<IBuildConfig>): void;
170170

171171
// @public
172172
export declare function parallel(...tasks: Array<IExecutable[] | IExecutable>): IExecutable;
@@ -189,7 +189,7 @@ class SchemaValidator {
189189
export declare function serial(...tasks: Array<IExecutable[] | IExecutable>): IExecutable;
190190

191191
// @public
192-
export declare function setConfig(config: IBuildConfig): void;
192+
export declare function setConfig(config: Partial<IBuildConfig>): void;
193193

194194
// @public
195195
export declare function subTask(taskName: string, fn: ICustomGulpTask): IExecutable;

‎core-build/gulp-core-build/src/index.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ let _buildConfig: IBuildConfig = {
8181
* @param config - The build config settings.
8282
* @public
8383
*/
84-
export function setConfig(config: IBuildConfig): void {
84+
export function setConfig(config: Partial<IBuildConfig>): void {
8585
/* tslint:disable:typedef */
8686
const objectAssign = require('object-assign');
8787
/* tslint:enable:typedef */
@@ -95,7 +95,7 @@ export function setConfig(config: IBuildConfig): void {
9595
* @param config - The build config settings.
9696
* @public
9797
*/
98-
export function mergeConfig(config: IBuildConfig): void {
98+
export function mergeConfig(config: Partial<IBuildConfig>): void {
9999
/* tslint:disable:typedef */
100100
const merge = require('lodash.merge');
101101
/* tslint:enable:typedef */

‎core-build/gulp-core-build/src/tests/index.test.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119,9 +119,9 @@ describe('parallel', () => {
119119

120120
it('can set the config', (done) => {
121121
const distFolder: string = 'testFolder';
122-
const newConfig: IBuildConfig = {
122+
const newConfig: Partial<IBuildConfig> = {
123123
distFolder: distFolder
124-
} as IBuildConfig;
124+
};
125125

126126
setConfig(newConfig);
127127
expect(getConfig().distFolder).to.eq(distFolder);

‎core-build/node-library-build/src/index.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ const PRODUCTION = process.argv.indexOf('--production') !== -1 || process.argv.i
1515
setConfig({
1616
production: PRODUCTION,
1717
shouldWarningsFailBuild: PRODUCTION
18-
} as IBuildConfig);
18+
});
1919

2020
tslint.mergeConfig({
2121
displayAsWarning: true

‎core-build/web-library-build/src/index.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ const PRODUCTION = !!getConfig().args['production'] || !!getConfig().args['ship'
4444
setConfig({
4545
production: PRODUCTION,
4646
shouldWarningsFailBuild: PRODUCTION
47-
} as IBuildConfig);
47+
});
4848

4949
tslint.mergeConfig({
5050
displayAsWarning: true

0 commit comments

Comments
 (0)