Clarify a message that people found confusing

pgonzal · pgonzal · commit 75e3f80cc37d · 2018-05-31T16:04:44.000-07:00
diff --git a/apps/rush-lib/src/cli/actions/CommandLineMigrationAdvisor.ts b/apps/rush-lib/src/cli/actions/CommandLineMigrationAdvisor.ts
@@ -24,16 +24,26 @@ export class CommandLineMigrationAdvisor {
       }
 
       if (args[0] === 'install') {
-        if (args.indexOf('-C') >= 0  || args.indexOf('--full-clean') >= 0) {
+        if (args.indexOf('--full-clean') >= 0) {
           CommandLineMigrationAdvisor._reportDeprecated(
             'Instead of "rush install --full-clean", use "rush purge --unsafe".');
           return false;
         }
-        if (args.indexOf('-c') >= 0  || args.indexOf('--clean') >= 0) {
+        if (args.indexOf('-C') >= 0) {
+          CommandLineMigrationAdvisor._reportDeprecated(
+            'Instead of "rush install -C", use "rush purge --unsafe".');
+          return false;
+        }
+        if (args.indexOf('--clean') >= 0) {
           CommandLineMigrationAdvisor._reportDeprecated(
             'Instead of "rush install --clean", use "rush install --purge".');
           return false;
         }
+        if (args.indexOf('-c') >= 0) {
+          CommandLineMigrationAdvisor._reportDeprecated(
+            'Instead of "rush install -c", use "rush install --purge".');
+          return false;
+        }
       }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -24,16 +24,26 @@ export class CommandLineMigrationAdvisor {`
`24`	`24`	`}`
`25`	`25`
`26`	`26`	`if (args[0] === 'install') {`
`27`		`- if (args.indexOf('-C') >= 0 \|\| args.indexOf('--full-clean') >= 0) {`
	`27`	`+ if (args.indexOf('--full-clean') >= 0) {`
`28`	`28`	`CommandLineMigrationAdvisor._reportDeprecated(`
`29`	`29`	`'Instead of "rush install --full-clean", use "rush purge --unsafe".');`
`30`	`30`	`return false;`
`31`	`31`	`}`
`32`		`- if (args.indexOf('-c') >= 0 \|\| args.indexOf('--clean') >= 0) {`
	`32`	`+ if (args.indexOf('-C') >= 0) {`
	`33`	`+ CommandLineMigrationAdvisor._reportDeprecated(`
	`34`	`+ 'Instead of "rush install -C", use "rush purge --unsafe".');`
	`35`	`+ return false;`
	`36`	`+ }`
	`37`	`+ if (args.indexOf('--clean') >= 0) {`
`33`	`38`	`CommandLineMigrationAdvisor._reportDeprecated(`
`34`	`39`	`'Instead of "rush install --clean", use "rush install --purge".');`
`35`	`40`	`return false;`
`36`	`41`	`}`
	`42`	`+ if (args.indexOf('-c') >= 0) {`
	`43`	`+ CommandLineMigrationAdvisor._reportDeprecated(`
	`44`	`+ 'Instead of "rush install -c", use "rush install --purge".');`
	`45`	`+ return false;`
	`46`	`+ }`
`37`	`47`	`}`
`38`	`48`	`}`
`39`	`49`