Rename "parallelized" to "enableParallelism" everywhere

pgonzal · pgonzal · commit 67458ed00565 · 2018-06-07T18:17:17.000-07:00
diff --git a/apps/rush-lib/src/cli/actions/CustomCommandFactory.ts b/apps/rush-lib/src/cli/actions/CustomCommandFactory.ts
@@ -40,7 +40,7 @@ export class CustomCommandFactory {
       parser: parser,
       commandLineConfiguration: commandLineConfiguration,
 
-      parallelized: true,
+      enableParallelism: true,
       ignoreMissingScript: false
     }));
 
@@ -52,7 +52,7 @@ export class CustomCommandFactory {
       parser: parser,
       commandLineConfiguration: commandLineConfiguration,
 
-      parallelized: true,
+      enableParallelism: true,
       ignoreMissingScript: false
     }));
 
@@ -73,7 +73,7 @@ export class CustomCommandFactory {
             parser: parser,
             commandLineConfiguration: commandLineConfiguration,
 
-            parallelized: command.parallelized,
+            enableParallelism: command.enableParallelism,
             ignoreMissingScript: command.ignoreMissingScript || false
           }));
           break;
diff --git a/apps/rush-lib/src/cli/actions/CustomRushAction.ts b/apps/rush-lib/src/cli/actions/CustomRushAction.ts
@@ -26,13 +26,13 @@ import { ParameterJson } from '../../data/CommandLineJson';
 import { RushConstants } from '../../RushConstants';
 
 export interface ICustomRushActionOptions extends IRushCommandLineActionOptions {
-  parallelized: boolean;
+  enableParallelism: boolean;
   ignoreMissingScript: boolean;
   commandLineConfiguration: CommandLineConfiguration;
 }
 
 export class CustomRushAction extends BaseRushAction {
-  private _parallelized: boolean;
+  private _enableParallelism: boolean;
   private _ignoreMissingScript: boolean;
   private _commandLineConfiguration: CommandLineConfiguration;
 
@@ -49,7 +49,7 @@ export class CustomRushAction extends BaseRushAction {
     options: ICustomRushActionOptions
   ) {
     super(options);
-    this._parallelized = options.parallelized;
+    this._enableParallelism = options.enableParallelism;
     this._ignoreMissingScript = options.ignoreMissingScript;
     this._commandLineConfiguration = options.commandLineConfiguration;
   }
@@ -66,8 +66,8 @@ export class CustomRushAction extends BaseRushAction {
     const isQuietMode: boolean = !(this._verboseParameter.value);
 
     // if this is parallizable, then use the value from the flag (undefined or a number),
-    // if this is not parallelized, then use 1 core
-    const parallelism: string | undefined = this._isParallelized()
+    // if parallelism is not enabled, then restrict to 1 core
+    const parallelism: string | undefined = this._isParallelismEnabled()
       ? this._parallelismParameter!.value
       : '1';
 
@@ -113,7 +113,7 @@ export class CustomRushAction extends BaseRushAction {
   }
 
   protected onDefineParameters(): void {
-    if (this._isParallelized()) {
+    if (this._isParallelismEnabled()) {
       this._parallelismParameter = this.defineStringParameter({
         parameterLongName: '--parallelism',
         parameterShortName: '-p',
@@ -209,10 +209,10 @@ export class CustomRushAction extends BaseRushAction {
     return projects;
   }
 
-  private _isParallelized(): boolean {
+  private _isParallelismEnabled(): boolean {
     return this.actionName === 'build'
       || this.actionName === 'rebuild'
-      || this._parallelized;
+      || this._enableParallelism;
   }
 
   private _doBeforeTask(): void {
diff --git a/apps/rush-lib/src/cli/actions/test/repo/common/config/rush/command-line.json b/apps/rush-lib/src/cli/actions/test/repo/common/config/rush/command-line.json
@@ -5,7 +5,7 @@
       "commandKind": "bulk",
       "summary": "Imports translated strings into each project.",
       "description": "Requests translated strings from the translation service and imports them into each project.",
-      "parallelized": true
+      "enableParallelism": true
     },
     {
       "name": "deploy",
diff --git a/apps/rush-lib/src/data/CommandLineJson.ts b/apps/rush-lib/src/data/CommandLineJson.ts
@@ -16,7 +16,7 @@ export interface IBaseCommandJson {
  */
 export interface IBulkCommandJson extends IBaseCommandJson {
   commandKind: 'bulk';
-  parallelized: boolean;
+  enableParallelism: boolean;
   ignoreMissingScript?: boolean;
 }
 
diff --git a/apps/rush-lib/src/schemas/command-line.schema.json b/apps/rush-lib/src/schemas/command-line.schema.json
@@ -53,14 +53,14 @@
         {
           "type": "object",
           "additionalProperties": true,
-          "required": [ "parallelized" ],
+          "required": [ "enableParallelism" ],
           "properties": {
             "commandKind": {
               "enum": [ "bulk" ]
             },
-            "parallelized": {
-              "title": "Parallelized",
-              "description": "Describes whether or not this command can be run in parallel (i.e. executed simultaneously for multiple projects).",
+            "enableParallelism": {
+              "title": "enableParallelism",
+              "description": "If true then this command can be run in parallel, i.e. executed simultaneously for multiple projects.",
               "type": "boolean"
             },
             "ignoreMissingScript": {
@@ -79,7 +79,7 @@
             "summary": { "$ref": "#/definitions/anything" },
             "description": { "$ref": "#/definitions/anything" },
 
-            "parallelized": { "$ref": "#/definitions/anything" },
+            "enableParallelism": { "$ref": "#/definitions/anything" },
             "ignoreMissingScript": { "$ref": "#/definitions/anything" }
           }
         }

Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@`
`5`	`5`	`"commandKind": "bulk",`
`6`	`6`	`"summary": "Imports translated strings into each project.",`
`7`	`7`	`"description": "Requests translated strings from the translation service and imports them into each project.",`
`8`		`- "parallelized": true`
	`8`	`+ "enableParallelism": true`
`9`	`9`	`},`
`10`	`10`	`{`
`11`	`11`	`"name": "deploy",`
Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ export interface IBaseCommandJson {`
`16`	`16`	`*/`
`17`	`17`	`export interface IBulkCommandJson extends IBaseCommandJson {`
`18`	`18`	`commandKind: 'bulk';`
`19`		`- parallelized: boolean;`
	`19`	`+ enableParallelism: boolean;`
`20`	`20`	`ignoreMissingScript?: boolean;`
`21`	`21`	`}`
`22`	`22`