Rename function based on PR feedback

pgonzal · pgonzal · commit 5b3590eb7ffa · 2018-07-17T14:54:33.000+09:00
diff --git a/libraries/rushell/src/AstNode.ts b/libraries/rushell/src/AstNode.ts
@@ -45,11 +45,11 @@ export abstract class AstNode {
 
   public getChildNodes(): AstNode[] {
     const nodes: AstNode[] = [];
-    this.pushChildNodes(nodes);
+    this.collectChildNodesInto(nodes);
     return nodes;
   }
 
-  protected abstract pushChildNodes(nodes: AstNode[]): void;
+  protected abstract collectChildNodesInto(nodes: AstNode[]): void;
 
   protected getDumpText(): string | undefined {
     return undefined;
@@ -64,7 +64,7 @@ export class AstScript extends AstNode {
   }
 
   /** @override */
-  protected pushChildNodes(nodes: AstNode[]): void {
+  protected collectChildNodesInto(nodes: AstNode[]): void {
     if (this.body) {
       nodes.push(this.body);
     }
@@ -87,7 +87,7 @@ export class AstAndIf extends AstNode {
   }
 
   /** @override */
-  protected pushChildNodes(nodes: AstNode[]): void {
+  protected collectChildNodesInto(nodes: AstNode[]): void {
     if (this.firstCommand) {
       nodes.push(this.firstCommand);
     }
@@ -106,7 +106,7 @@ export class AstCommand extends AstNode {
   }
 
   /** @override */
-  protected pushChildNodes(nodes: AstNode[]): void {
+  protected collectChildNodesInto(nodes: AstNode[]): void {
     if (this.commandPath) {
       nodes.push(this.commandPath);
     }
@@ -122,7 +122,7 @@ export class AstCompoundWord extends AstNode {
   }
 
   /** @override */
-  protected pushChildNodes(nodes: AstNode[]): void {
+  protected collectChildNodesInto(nodes: AstNode[]): void {
     nodes.push(...this.parts);
   }
 }
@@ -133,7 +133,7 @@ export class AstVariableExpansion extends AstNode {
   }
 
   /** @override */
-  protected pushChildNodes(nodes: AstNode[]): void {
+  protected collectChildNodesInto(nodes: AstNode[]): void {
     // no children
   }
 }
@@ -145,7 +145,7 @@ export class AstText extends AstNode {
   }
 
   /** @override */
-  protected pushChildNodes(nodes: AstNode[]): void {
+  protected collectChildNodesInto(nodes: AstNode[]): void {
     // no children
   }
 

Original file line number	Diff line number	Diff line change
`@@ -45,11 +45,11 @@ export abstract class AstNode {`
`45`	`45`
`46`	`46`	`public getChildNodes(): AstNode[] {`
`47`	`47`	`const nodes: AstNode[] = [];`
`48`		`- this.pushChildNodes(nodes);`
	`48`	`+ this.collectChildNodesInto(nodes);`
`49`	`49`	`return nodes;`
`50`	`50`	`}`
`51`	`51`
`52`		`- protected abstract pushChildNodes(nodes: AstNode[]): void;`
	`52`	`+ protected abstract collectChildNodesInto(nodes: AstNode[]): void;`
`53`	`53`
`54`	`54`	`protected getDumpText(): string \| undefined {`
`55`	`55`	`return undefined;`
`@@ -64,7 +64,7 @@ export class AstScript extends AstNode {`
`64`	`64`	`}`
`65`	`65`
`66`	`66`	`/** @override */`
`67`		`- protected pushChildNodes(nodes: AstNode[]): void {`
	`67`	`+ protected collectChildNodesInto(nodes: AstNode[]): void {`
`68`	`68`	`if (this.body) {`
`69`	`69`	`nodes.push(this.body);`
`70`	`70`	`}`
`@@ -87,7 +87,7 @@ export class AstAndIf extends AstNode {`
`87`	`87`	`}`
`88`	`88`
`89`	`89`	`/** @override */`
`90`		`- protected pushChildNodes(nodes: AstNode[]): void {`
	`90`	`+ protected collectChildNodesInto(nodes: AstNode[]): void {`
`91`	`91`	`if (this.firstCommand) {`
`92`	`92`	`nodes.push(this.firstCommand);`
`93`	`93`	`}`
`@@ -106,7 +106,7 @@ export class AstCommand extends AstNode {`
`106`	`106`	`}`
`107`	`107`
`108`	`108`	`/** @override */`
`109`		`- protected pushChildNodes(nodes: AstNode[]): void {`
	`109`	`+ protected collectChildNodesInto(nodes: AstNode[]): void {`
`110`	`110`	`if (this.commandPath) {`
`111`	`111`	`nodes.push(this.commandPath);`
`112`	`112`	`}`
`@@ -122,7 +122,7 @@ export class AstCompoundWord extends AstNode {`
`122`	`122`	`}`
`123`	`123`
`124`	`124`	`/** @override */`
`125`		`- protected pushChildNodes(nodes: AstNode[]): void {`
	`125`	`+ protected collectChildNodesInto(nodes: AstNode[]): void {`
`126`	`126`	`nodes.push(...this.parts);`
`127`	`127`	`}`
`128`	`128`	`}`
`@@ -133,7 +133,7 @@ export class AstVariableExpansion extends AstNode {`
`133`	`133`	`}`
`134`	`134`
`135`	`135`	`/** @override */`
`136`		`- protected pushChildNodes(nodes: AstNode[]): void {`
	`136`	`+ protected collectChildNodesInto(nodes: AstNode[]): void {`
`137`	`137`	`// no children`
`138`	`138`	`}`
`139`	`139`	`}`
`@@ -145,7 +145,7 @@ export class AstText extends AstNode {`
`145`	`145`	`}`
`146`	`146`
`147`	`147`	`/** @override */`
`148`		`- protected pushChildNodes(nodes: AstNode[]): void {`
	`148`	`+ protected collectChildNodesInto(nodes: AstNode[]): void {`
`149`	`149`	`// no children`
`150`	`150`	`}`
`151`	`151`