Treat warnings as errors in production mode when building node-library-build & web-library-build (microsoft#499)

Nicholas Pape · web-flow · commit 49a31bb67ddc · 2018-01-22T12:48:39.000-08:00
* Errors as warnings in web-library-build and node-library-build

* Changefiles
diff --git a/common/changes/@microsoft/node-library-build/nickpape-errors-as-warnings_2018-01-18-22-09.json b/common/changes/@microsoft/node-library-build/nickpape-errors-as-warnings_2018-01-18-22-09.json
@@ -0,0 +1,11 @@
+{
+  "changes": [
+    {
+      "comment": "",
+      "packageName": "@microsoft/node-library-build",
+      "type": "none"
+    }
+  ],
+  "packageName": "@microsoft/node-library-build",
+  "email": "nickpape-msft@users.noreply.github.com"
+}
diff --git a/common/changes/@microsoft/web-library-build/nickpape-errors-as-warnings_2018-01-18-22-09.json b/common/changes/@microsoft/web-library-build/nickpape-errors-as-warnings_2018-01-18-22-09.json
@@ -0,0 +1,11 @@
+{
+  "changes": [
+    {
+      "comment": "",
+      "packageName": "@microsoft/web-library-build",
+      "type": "none"
+    }
+  ],
+  "packageName": "@microsoft/web-library-build",
+  "email": "nickpape-msft@users.noreply.github.com"
+}
diff --git a/core-build/node-library-build/gulpfile.js b/core-build/node-library-build/gulpfile.js
@@ -5,6 +5,10 @@ let apiExtractor = require('@microsoft/gulp-core-build-typescript').apiExtractor
 let typescript = require('@microsoft/gulp-core-build-typescript').typescript;
 let mocha = require('@microsoft/gulp-core-build-mocha');
 
+build.setConfig({
+  shouldWarningsFailBuild: build.getConfig().production
+});
+
 build.task('default', build.serial(typescript, mocha, apiExtractor));
 
 build.initialize(require('gulp'));
diff --git a/core-build/web-library-build/gulpfile.js b/core-build/web-library-build/gulpfile.js
@@ -4,6 +4,10 @@ let build = require('@microsoft/gulp-core-build');
 let typescript = require('@microsoft/gulp-core-build-typescript').typescript;
 let apiExtractor = require('@microsoft/gulp-core-build-typescript').apiExtractor;
 
+build.setConfig({
+  shouldWarningsFailBuild: build.getConfig().production
+});
+
 build.task('default', build.serial(typescript, apiExtractor));
 
 build.initialize(require('gulp'));
