Allowing the option to ignore dependencies when running bulk commands to allow running things like UT and Lint that don't require dependency order execution

aboktor · aboktor · commit 43cc46427000 · 2019-05-16T17:26:19.000-07:00
diff --git a/apps/rush-lib/src/api/CommandLineJson.ts b/apps/rush-lib/src/api/CommandLineJson.ts
@@ -22,6 +22,7 @@ export interface IBulkCommandJson extends IBaseCommandJson {
   commandKind: 'bulk';
   enableParallelism: boolean;
   ignoreMissingScript?: boolean;
+  ignoreDependencies?: boolean;
 }
 
 /**
diff --git a/apps/rush-lib/src/cli/scriptActions/BulkScriptAction.ts b/apps/rush-lib/src/cli/scriptActions/BulkScriptAction.ts
@@ -28,6 +28,7 @@ import { FileSystem } from '@microsoft/node-core-library';
 export interface IBulkScriptActionOptions extends IBaseScriptActionOptions {
   enableParallelism: boolean;
   ignoreMissingScript: boolean;
+  ignoreDependencies?: boolean;
 
   /**
    * Optional command to run. Otherwise, use the `actionName` as the command to run.
@@ -55,6 +56,7 @@ export class BulkScriptAction extends BaseScriptAction {
   private _toVersionPolicy: CommandLineStringListParameter;
   private _verboseParameter: CommandLineFlagParameter;
   private _parallelismParameter: CommandLineStringParameter | undefined;
+  private _ignoreDependencies: boolean;
 
   constructor(
     options: IBulkScriptActionOptions
@@ -63,6 +65,7 @@ export class BulkScriptAction extends BaseScriptAction {
     this._enableParallelism = options.enableParallelism;
     this._ignoreMissingScript = options.ignoreMissingScript;
     this._commandToRun = options.commandToRun || options.actionName;
+    this._ignoreDependencies = !! options.ignoreDependencies;
   }
 
   public run(): Promise<void> {
@@ -102,7 +105,8 @@ export class BulkScriptAction extends BaseScriptAction {
         parallelism,
         isIncrementalBuildAllowed: this.actionName === 'build',
         changedProjectsOnly,
-        ignoreMissingScript: this._ignoreMissingScript
+        ignoreMissingScript: this._ignoreMissingScript,
+        ignoreDependencies: this._ignoreDependencies
       }
     );
 
diff --git a/apps/rush-lib/src/logic/TaskSelector.ts b/apps/rush-lib/src/logic/TaskSelector.ts
@@ -20,6 +20,7 @@ export interface ITaskSelectorConstructor {
   isIncrementalBuildAllowed: boolean;
   changedProjectsOnly: boolean;
   ignoreMissingScript: boolean;
+  ignoreDependencies: boolean;
 }
 
 /**
@@ -60,7 +61,7 @@ export class TaskSelector {
       this._registerFromFlags(this._options.fromFlags);
     }
     if (this._options.toFlags.length === 0 && this._options.fromFlags.length === 0) {
-      this._registerAll();
+      this._registerAll(this._options.ignoreDependencies);
     }
   }
 
@@ -114,15 +115,17 @@ export class TaskSelector {
     }
   }
 
-  private _registerAll(): void {
+  private _registerAll(addDependencies: boolean): void {
+    console.log(addDependencies);
     // Register all tasks
     for (const rushProject of this._options.rushConfiguration.projects) {
       this._registerTask(rushProject);
     }
-
-    // Add all dependencies
-    for (const projectName of Object.keys(this._rushLinkJson.localLinks)) {
-      this._taskRunner.addDependencies(projectName, this._rushLinkJson.localLinks[projectName]);
+    if (addDependencies) {
+       // Add all dependencies
+      for (const projectName of Object.keys(this._rushLinkJson.localLinks)) {
+        this._taskRunner.addDependencies(projectName, this._rushLinkJson.localLinks[projectName]);
+      }
     }
   }
 
diff --git a/apps/rush-lib/src/schemas/command-line.schema.json b/apps/rush-lib/src/schemas/command-line.schema.json
@@ -72,6 +72,11 @@
               "title": "Ignore Missing Script",
               "description": "Normally Rush requires that each project's package.json has a \"scripts\" entry matching the custom command name. To disable this check, set \"ignoreMissingScript\" to true.",
               "type": "boolean"
+            },
+            "ignoreDependencies": {
+              "title": "Ignore dependency relation between projects and just run everything in parallel",
+              "description": "Ignore dependency relation between projects and just run everything in parallel",
+              "type": "boolean"
             }
           }
         },
@@ -86,7 +91,8 @@
             "safeForSimultaneousRushProcesses": { "$ref": "#/definitions/anything" },
 
             "enableParallelism": { "$ref": "#/definitions/anything" },
-            "ignoreMissingScript": { "$ref": "#/definitions/anything" }
+            "ignoreMissingScript": { "$ref": "#/definitions/anything" },
+            "ignoreDependencies": { "$ref": "#/definitions/anything" }
           }
         }
       ]

Original file line number	Diff line number	Diff line change
`@@ -22,6 +22,7 @@ export interface IBulkCommandJson extends IBaseCommandJson {`
`22`	`22`	`commandKind: 'bulk';`
`23`	`23`	`enableParallelism: boolean;`
`24`	`24`	`ignoreMissingScript?: boolean;`
	`25`	`+ ignoreDependencies?: boolean;`
`25`	`26`	`}`
`26`	`27`
`27`	`28`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -20,6 +20,7 @@ export interface ITaskSelectorConstructor {`
`20`	`20`	`isIncrementalBuildAllowed: boolean;`
`21`	`21`	`changedProjectsOnly: boolean;`
`22`	`22`	`ignoreMissingScript: boolean;`
	`23`	`+ ignoreDependencies: boolean;`
`23`	`24`	`}`
`24`	`25`
`25`	`26`	`/**`
`@@ -60,7 +61,7 @@ export class TaskSelector {`
`60`	`61`	`this._registerFromFlags(this._options.fromFlags);`
`61`	`62`	`}`
`62`	`63`	`if (this._options.toFlags.length === 0 && this._options.fromFlags.length === 0) {`
`63`		`- this._registerAll();`
	`64`	`+ this._registerAll(this._options.ignoreDependencies);`
`64`	`65`	`}`
`65`	`66`	`}`
`66`	`67`
`@@ -114,15 +115,17 @@ export class TaskSelector {`
`114`	`115`	`}`
`115`	`116`	`}`
`116`	`117`
`117`		`- private _registerAll(): void {`
	`118`	`+ private _registerAll(addDependencies: boolean): void {`
	`119`	`+ console.log(addDependencies);`
`118`	`120`	`// Register all tasks`
`119`	`121`	`for (const rushProject of this._options.rushConfiguration.projects) {`
`120`	`122`	`this._registerTask(rushProject);`
`121`	`123`	`}`
`122`		`-`
`123`		`- // Add all dependencies`
`124`		`- for (const projectName of Object.keys(this._rushLinkJson.localLinks)) {`
`125`		`- this._taskRunner.addDependencies(projectName, this._rushLinkJson.localLinks[projectName]);`
	`124`	`+ if (addDependencies) {`
	`125`	`+ // Add all dependencies`
	`126`	`+ for (const projectName of Object.keys(this._rushLinkJson.localLinks)) {`
	`127`	`+ this._taskRunner.addDependencies(projectName, this._rushLinkJson.localLinks[projectName]);`
	`128`	`+ }`
`126`	`129`	`}`
`127`	`130`	`}`
`128`	`131`
Original file line number	Diff line number	Diff line change
`@@ -72,6 +72,11 @@`
`72`	`72`	`"title": "Ignore Missing Script",`
`73`	`73`	`"description": "Normally Rush requires that each project's package.json has a \"scripts\" entry matching the custom command name. To disable this check, set \"ignoreMissingScript\" to true.",`
`74`	`74`	`"type": "boolean"`
	`75`	`+ },`
	`76`	`+ "ignoreDependencies": {`
	`77`	`+ "title": "Ignore dependency relation between projects and just run everything in parallel",`
	`78`	`+ "description": "Ignore dependency relation between projects and just run everything in parallel",`
	`79`	`+ "type": "boolean"`
`75`	`80`	`}`
`76`	`81`	`}`
`77`	`82`	`},`
`@@ -86,7 +91,8 @@`
`86`	`91`	`"safeForSimultaneousRushProcesses": { "$ref": "#/definitions/anything" },`
`87`	`92`
`88`	`93`	`"enableParallelism": { "$ref": "#/definitions/anything" },`
`89`		`- "ignoreMissingScript": { "$ref": "#/definitions/anything" }`
	`94`	`+ "ignoreMissingScript": { "$ref": "#/definitions/anything" },`
	`95`	`+ "ignoreDependencies": { "$ref": "#/definitions/anything" }`
`90`	`96`	`}`
`91`	`97`	`}`
`92`	`98`	`]`