Improve telemetry formatting based on PR feedback

pgonzal · pgonzal · commit 386879e648e3 · 2018-06-07T18:17:17.000-07:00
diff --git a/apps/rush-lib/src/cli/actions/CustomRushAction.ts b/apps/rush-lib/src/cli/actions/CustomRushAction.ts
@@ -13,7 +13,8 @@ import {
   CommandLineParameter,
   CommandLineFlagParameter,
   CommandLineStringParameter,
-  CommandLineStringListParameter
+  CommandLineStringListParameter,
+  CommandLineParameterKind
 } from '@microsoft/ts-command-line';
 
 import { BaseRushAction, IRushCommandLineActionOptions } from './BaseRushAction';
@@ -238,17 +239,25 @@ export class CustomRushAction extends BaseRushAction {
 
   private _collectTelemetry(stopwatch: Stopwatch, success: boolean): void {
 
-    const customParameterValues: string[] = [];
-    for (const customParameter of this._customParameters) {
-      customParameter.appendToArgList(customParameterValues);
-    }
-
     const extraData: { [key: string]: string } = {
       command_to: (this._toFlag.values.length > 0).toString(),
-      command_from: (this._fromFlag.values.length > 0).toString(),
-      customParameters: customParameterValues.join(' ')
+      command_from: (this._fromFlag.values.length > 0).toString()
     };
 
+    for (const customParameter of this._customParameters) {
+      switch (customParameter.kind) {
+        case CommandLineParameterKind.Flag:
+        case CommandLineParameterKind.Choice:
+        case CommandLineParameterKind.String:
+        case CommandLineParameterKind.Integer:
+          // tslint:disable-next-line:no-any
+          extraData[customParameter.longName] = JSON.stringify((customParameter as any).value);
+          break;
+        default:
+          extraData[customParameter.longName] = '?';
+      }
+    }
+
     if (this.parser.telemetry) {
       this.parser.telemetry.log({
         name: this.actionName,
