Skip to content

Commit 1fae2f9

Browse files
committed
Refactor certificates functions into CertificateManager class.
1 parent f5717c8 commit 1fae2f9

File tree

8 files changed

+453
-424
lines changed

8 files changed

+453
-424
lines changed

common/reviews/api/debug-certificate-manager.api.md

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,13 @@
66

77
import { Terminal } from '@microsoft/node-core-library';
88

9+
// @public
10+
export class CertificateManager {
11+
constructor();
12+
ensureCertificate(canGenerateNewCertificate: boolean, terminal: Terminal): ICertificate;
13+
untrustCertificate(terminal: Terminal): boolean;
14+
}
15+
916
// @public
1017
export class CertificateStore {
1118
constructor();
@@ -14,17 +21,11 @@ export class CertificateStore {
1421
keyData: string | undefined;
1522
}
1623

17-
// @public
18-
export function ensureCertificate(canGenerateNewCertificate: boolean, terminal: Terminal): ICertificate;
19-
2024
// @public
2125
export interface ICertificate {
2226
pemCertificate: string | undefined;
2327
pemKey: string | undefined;
2428
}
2529

26-
// @public
27-
export function untrustCertificate(terminal: Terminal): boolean;
28-
2930

3031
```

core-build/gulp-core-build-serve/src/ServeTask.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import * as ExpressType from 'express';
1515

1616
import {
1717
ICertificate,
18-
ensureCertificate
18+
CertificateManager
1919
} from '@rushstack/debug-certificate-manager';
2020

2121
/**
@@ -297,7 +297,8 @@ export class ServeTask<TExtendedConfig = {}> extends GulpTask<IServeTaskConfig &
297297
}
298298
}
299299
} else {
300-
const devCertificate: ICertificate = ensureCertificate(
300+
const certificateManager: CertificateManager = new CertificateManager();
301+
const devCertificate: ICertificate = certificateManager.ensureCertificate(
301302
this.taskConfig.tryCreateDevCertificate,
302303
this._terminal
303304
);

core-build/gulp-core-build-serve/src/TrustCertTask.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import {
88
import * as Gulp from 'gulp';
99
import {
1010
ICertificate,
11-
ensureCertificate
11+
CertificateManager
1212
} from '@rushstack/debug-certificate-manager';
1313
import { Terminal } from '@microsoft/node-core-library';
1414

@@ -30,7 +30,8 @@ export class TrustCertTask extends GulpTask<void> {
3030
}
3131

3232
public executeTask(gulp: typeof Gulp, completeCallback: (error?: string) => void): void {
33-
const certificate: ICertificate = ensureCertificate(true, this._terminal);
33+
const certificateManager: CertificateManager = new CertificateManager();
34+
const certificate: ICertificate = certificateManager.ensureCertificate(true, this._terminal);
3435

3536
if (certificate.pemCertificate && certificate.pemKey) {
3637
completeCallback();

core-build/gulp-core-build-serve/src/UntrustCertTask.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import { Terminal } from '@microsoft/node-core-library';
99
import * as Gulp from 'gulp';
1010
import {
1111
CertificateStore,
12-
untrustCertificate
12+
CertificateManager
1313
} from '@rushstack/debug-certificate-manager';
1414

1515
/**
@@ -31,7 +31,8 @@ export class UntrustCertTask extends GulpTask<void> {
3131
}
3232

3333
public executeTask(gulp: typeof Gulp, completeCallback: (error?: string) => void): void {
34-
const untrustCertResult: boolean = untrustCertificate(this._terminal);
34+
const certificateManager: CertificateManager = new CertificateManager();
35+
const untrustCertResult: boolean = certificateManager.untrustCertificate(this._terminal);
3536
const certificateStore: CertificateStore = new CertificateStore();
3637

3738
// Clear out the certificate store

0 commit comments

Comments
 (0)