Add unit test that repros GitHub microsoft#1679

octogonz · octogonz · commit 197493f85d13 · 2020-01-10T09:11:28.000-08:00
diff --git a/build-tests/api-extractor-scenarios/config/build-config.json b/build-tests/api-extractor-scenarios/config/build-config.json
@@ -2,6 +2,7 @@
   "scenarioFolderNames": [
     "ambientNameConflict",
     "ambientNameConflict2",
+    "ancillaryDeclarations",
     "apiItemKinds",
     "bundledPackages",
     "circularImport",
diff --git a/build-tests/api-extractor-scenarios/etc/test-outputs/ancillaryDeclarations/api-extractor-scenarios.api.json b/build-tests/api-extractor-scenarios/etc/test-outputs/ancillaryDeclarations/api-extractor-scenarios.api.json
@@ -0,0 +1,36 @@
+{
+  "metadata": {
+    "toolPackage": "@microsoft/api-extractor",
+    "toolVersion": "[test mode]",
+    "schemaVersion": 1003,
+    "oldestForwardsCompatibleVersion": 1001
+  },
+  "kind": "Package",
+  "canonicalReference": "api-extractor-scenarios!",
+  "docComment": "",
+  "name": "api-extractor-scenarios",
+  "members": [
+    {
+      "kind": "EntryPoint",
+      "canonicalReference": "api-extractor-scenarios!",
+      "name": "",
+      "members": [
+        {
+          "kind": "Class",
+          "canonicalReference": "api-extractor-scenarios!MyClass:class",
+          "docComment": "/**\n * @public\n */\n",
+          "excerptTokens": [
+            {
+              "kind": "Content",
+              "text": "export declare class MyClass "
+            }
+          ],
+          "releaseTag": "Public",
+          "name": "MyClass",
+          "members": [],
+          "implementsTokenRanges": []
+        }
+      ]
+    }
+  ]
+}
diff --git a/build-tests/api-extractor-scenarios/etc/test-outputs/ancillaryDeclarations/api-extractor-scenarios.api.md b/build-tests/api-extractor-scenarios/etc/test-outputs/ancillaryDeclarations/api-extractor-scenarios.api.md
@@ -0,0 +1,24 @@
+## API Report File for "api-extractor-scenarios"
+
+> Do not edit this file. It is a report generated by [API Extractor](https://api-extractor.com/).
+
+```ts
+
+// @internal (undocumented)
+export interface _IInternalThing {
+    // (undocumented)
+    title: string;
+}
+
+// @public (undocumented)
+export class MyClass {
+    // @internal (undocumented)
+    get _thing(): _IInternalThing;
+    // Warning: (ae-incompatible-release-tags) The symbol "_thing" is marked as @public, but its signature references "_IInternalThing" which is marked as @internal
+    set _thing(value: _IInternalThing);
+}
+
+
+// (No @packageDocumentation comment for this package)
+
+```
diff --git a/build-tests/api-extractor-scenarios/etc/test-outputs/ancillaryDeclarations/rollup.d.ts b/build-tests/api-extractor-scenarios/etc/test-outputs/ancillaryDeclarations/rollup.d.ts
@@ -0,0 +1,14 @@
+
+/** @internal */
+export declare interface _IInternalThing {
+    title: string;
+}
+
+/** @public */
+export declare class MyClass {
+    /** @internal */
+    get _thing(): _IInternalThing;
+    set _thing(value: _IInternalThing);
+}
+
+export { }
diff --git a/build-tests/api-extractor-scenarios/src/ancillaryDeclarations/index.ts b/build-tests/api-extractor-scenarios/src/ancillaryDeclarations/index.ts
@@ -0,0 +1,18 @@
+// Copyright (c) Microsoft Corporation. All rights reserved. Licensed under the MIT license.
+// See LICENSE in the project root for license information.
+
+/** @internal */
+export interface _IInternalThing {
+  title: string;
+}
+
+/** @public */
+export class MyClass {
+  /** @internal */
+  public get _thing(): _IInternalThing {
+    return { title: 'thing' };
+  }
+  // The setter should also be considered @internal because the getter was marked as internal.
+  public set _thing(value: _IInternalThing) {
+  }
+}
