Fix ESLint issues for the rest of libraries/*

octogonz · octogonz · commit 1558d762896d · 2019-10-21T00:20:09.000-07:00
diff --git a/libraries/load-themed-styles/.eslintrc.js b/libraries/load-themed-styles/.eslintrc.js
@@ -0,0 +1,7 @@
+// This is a workaround for https://github.com/eslint/eslint/issues/3458
+require("@rushstack/eslint-config/patch-eslint6");
+
+module.exports = {
+  extends: [ "@rushstack/eslint-config" ],
+  parserOptions: { tsconfigRootDir: __dirname },
+};
diff --git a/libraries/load-themed-styles/src/index.ts b/libraries/load-themed-styles/src/index.ts
@@ -5,15 +5,15 @@
 
 // Declaring a global here in case that the execution environment is Node.js (without importing the
 // entire node.js d.ts for now)
-declare var global: any; // eslint-disable-line @typescript-eslint/no-explicit-any
+declare let global: any; // eslint-disable-line @typescript-eslint/no-explicit-any
 
 export interface IThemingInstruction {
   theme?: string;
   defaultValue?: string;
   rawString?: string;
 }
 
-export type ThemableArray = Array<IThemingInstruction>;
+export type ThemableArray = IThemingInstruction[];
 
 export interface ITheme {
   [key: string]: string;
@@ -350,7 +350,7 @@ export function splitStyles(styles: string): ThemableArray {
   if (styles) {
     let pos: number = 0; // Current position in styles.
     let tokenMatch: RegExpExecArray | null; // eslint-disable-line no-restricted-syntax
-    while (tokenMatch = _themeTokenRegex.exec(styles)) {
+    while (tokenMatch = _themeTokenRegex.exec(styles)) { // eslint-disable-line no-cond-assign
       const matchIndex: number = tokenMatch.index;
       if (matchIndex > pos) {
         result.push({
diff --git a/libraries/load-themed-styles/tslint.json b/libraries/load-themed-styles/tslint.json
diff --git a/libraries/package-deps-hash/.eslintrc.js b/libraries/package-deps-hash/.eslintrc.js
@@ -0,0 +1,7 @@
+// This is a workaround for https://github.com/eslint/eslint/issues/3458
+require("@rushstack/eslint-config/patch-eslint6");
+
+module.exports = {
+  extends: [ "@rushstack/eslint-config" ],
+  parserOptions: { tsconfigRootDir: __dirname },
+};
diff --git a/libraries/package-deps-hash/src/getPackageDeps.ts b/libraries/package-deps-hash/src/getPackageDeps.ts
@@ -178,7 +178,7 @@ export function getPackageDeps(packagePath: string = process.cwd(), excludedPath
   const excludedHashes: { [key: string]: boolean } = {};
 
   if (excludedPaths) {
-    excludedPaths.forEach(path => excludedHashes[path] = true);
+    excludedPaths.forEach((path) => { excludedHashes[path] = true });
   }
 
   const changes: IPackageDeps = {
diff --git a/libraries/package-deps-hash/tslint.json b/libraries/package-deps-hash/tslint.json
diff --git a/libraries/rushell/.eslintrc.js b/libraries/rushell/.eslintrc.js
@@ -0,0 +1,7 @@
+// This is a workaround for https://github.com/eslint/eslint/issues/3458
+require("@rushstack/eslint-config/patch-eslint6");
+
+module.exports = {
+  extends: [ "@rushstack/eslint-config" ],
+  parserOptions: { tsconfigRootDir: __dirname },
+};
diff --git a/libraries/rushell/src/Parser.ts b/libraries/rushell/src/Parser.ts
@@ -69,7 +69,7 @@ export class Parser {
   private _parseCompoundWord(): AstCompoundWord | undefined {
     const compoundWord: AstCompoundWord = new AstCompoundWord();
 
-    while (true) {
+    for (;;) {
       const node: AstNode | undefined = this._parseText();
       if (!node) {
         break;
diff --git a/libraries/rushell/src/Tokenizer.ts b/libraries/rushell/src/Tokenizer.ts
@@ -73,7 +73,7 @@ export class Tokenizer {
     return c === ' ' || c === '\t';
   }
 
-  constructor(input: TextRange | string) {
+  public constructor(input: TextRange | string) {
     if (typeof(input) === 'string') {
       this.input = TextRange.fromString(input);
     } else {
diff --git a/libraries/rushell/tslint.json b/libraries/rushell/tslint.json
diff --git a/libraries/stream-collator/.eslintrc.js b/libraries/stream-collator/.eslintrc.js
@@ -0,0 +1,7 @@
+// This is a workaround for https://github.com/eslint/eslint/issues/3458
+require("@rushstack/eslint-config/patch-eslint6");
+
+module.exports = {
+  extends: [ "@rushstack/eslint-config" ],
+  parserOptions: { tsconfigRootDir: __dirname },
+};
diff --git a/libraries/stream-collator/tslint.json b/libraries/stream-collator/tslint.json

Original file line number	Diff line number	Diff line change
`@@ -178,7 +178,7 @@ export function getPackageDeps(packagePath: string = process.cwd(), excludedPath`
`178`	`178`	`const excludedHashes: { [key: string]: boolean } = {};`
`179`	`179`
`180`	`180`	`if (excludedPaths) {`
`181`		`- excludedPaths.forEach(path => excludedHashes[path] = true);`
	`181`	`+ excludedPaths.forEach((path) => { excludedHashes[path] = true });`
`182`	`182`	`}`
`183`	`183`
`184`	`184`	`const changes: IPackageDeps = {`
Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,7 @@ export class Tokenizer {`
`73`	`73`	`return c === ' ' \|\| c === '\t';`
`74`	`74`	`}`
`75`	`75`
`76`		`- constructor(input: TextRange \| string) {`
	`76`	`+ public constructor(input: TextRange \| string) {`
`77`	`77`	`if (typeof(input) === 'string') {`
`78`	`78`	`this.input = TextRange.fromString(input);`
`79`	`79`	`} else {`