Fixing no-unused-variable issues.

iclanton · iclanton · commit 09f5902c8da2 · 2017-08-15T20:31:36.000-07:00
diff --git a/apps/rush-lib/src/data/ApprovedPackagesPolicy.ts b/apps/rush-lib/src/data/ApprovedPackagesPolicy.ts
@@ -3,7 +3,6 @@
 
 import * as path from 'path';
 
-import RushConfigurationProject, { IRushConfigurationProjectJson } from './RushConfigurationProject';
 import { ApprovedPackagesConfiguration } from './ApprovedPackagesConfiguration';
 import { RushConstants } from '../RushConstants';
 import RushConfiguration, { IRushConfigurationJson, IApprovedPackagesPolicyJson } from './RushConfiguration';
diff --git a/apps/rush-lib/src/utilities/JsonSchemaValidator.ts b/apps/rush-lib/src/utilities/JsonSchemaValidator.ts
@@ -3,7 +3,6 @@
 
 import Validator = require('z-schema');
 import * as os from 'os';
-import * as path from 'path';
 import JsonFile from './JsonFile';
 
 export type ValidateErrorCallback = (errorDescription: string) => void;
diff --git a/apps/rush/src/actions/InstallAction.ts b/apps/rush/src/actions/InstallAction.ts
@@ -7,7 +7,6 @@ import * as os from 'os';
 import { CommandLineFlagParameter } from '@microsoft/ts-command-line';
 import {
   Stopwatch,
-  IPackageJson,
   Event
 } from '@microsoft/rush-lib';
 
@@ -19,12 +18,6 @@ import ShrinkwrapFile from '../utilities/ShrinkwrapFile';
 import { ApprovedPackagesChecker } from '../utilities/ApprovedPackagesChecker';
 import { BaseRushAction } from './BaseRushAction';
 
-interface ITempModuleInformation {
-  packageJson: IPackageJson;
-  existsInProjectConfiguration: boolean;
-  filename: string;
-}
-
 export default class InstallAction extends BaseRushAction {
   private _parser: RushCommandLineParser;
   private _cleanInstall: CommandLineFlagParameter;
diff --git a/apps/rush/src/actions/PublishAction.ts b/apps/rush/src/actions/PublishAction.ts
@@ -16,9 +16,7 @@ import {
   Npm
 } from '@microsoft/rush-lib';
 import RushCommandLineParser from './RushCommandLineParser';
-import PublishUtilities, {
-  IChangeInfoHash
-} from '../utilities/PublishUtilities';
+import PublishUtilities from '../utilities/PublishUtilities';
 import ChangelogGenerator from '../utilities/ChangelogGenerator';
 import GitPolicy from '../utilities/GitPolicy';
 import PrereleaseToken from '../utilities/PrereleaseToken';
diff --git a/apps/rush/src/actions/RebuildAction.ts b/apps/rush/src/actions/RebuildAction.ts
@@ -44,7 +44,6 @@ export default class RebuildAction extends BaseRushAction {
   private _parallelismParameter: CommandLineIntegerParameter;
   private _parser: RushCommandLineParser;
   private _productionParameter: CommandLineFlagParameter;
-  private _quietParameter: CommandLineFlagParameter;
   private _toFlag: CommandLineStringListParameter;
   private _vsoParameter: CommandLineFlagParameter;
   private _minimalParameter: CommandLineFlagParameter;
diff --git a/apps/rush/src/utilities/ChangeFiles.ts b/apps/rush/src/utilities/ChangeFiles.ts
@@ -2,7 +2,6 @@
 // See LICENSE in the project root for license information.
 
 import * as fsx from 'fs-extra';
-import * as path from 'path';
 import { EOL } from 'os';
 import {
   Utilities,
diff --git a/apps/rush/src/utilities/VersionManager.ts b/apps/rush/src/utilities/VersionManager.ts
@@ -31,7 +31,6 @@ export class VersionManager {
    */
   public ensure(versionPolicyName?: string): Map<string, IPackageJson> {
     const updatedProjects: Map<string, IPackageJson> = new Map<string, IPackageJson>();
-    const versionPolicies: Map<string, VersionPolicy> = this._versionPolicyConfiguration.versionPolicies;
 
     // Update versions based on version policy
     this._rushConfiguration.projects.forEach(rushProject => {
diff --git a/apps/rush/src/utilities/test/PackageChangeAnalyzer.test.ts b/apps/rush/src/utilities/test/PackageChangeAnalyzer.test.ts
@@ -13,11 +13,12 @@ import {
 const packageA: string = 'project-a';
 const packageAPath: string = path.join('tools', packageA);
 const fileA: string = path.join(packageAPath, 'src/index.ts');
-const packageB: string = 'project-b';
-const packageBPath: string = path.join('tools', packageB);
-const fileB: string = path.join(packageBPath, 'src/index.ts');
+// const packageB: string = 'project-b';
+// const packageBPath: string = path.join('tools', packageB);
+// const fileB: string = path.join(packageBPath, 'src/index.ts');
+// const packageBPath: string = path.join('tools', packageB);
 const HASH: string = '12345abcdef';
-const looseFile: string = 'some/other/folder/index.ts';
+// const looseFile: string = 'some/other/folder/index.ts';
 
 describe('PackageChangeAnalyzer', () => {
   afterEach(() => {
diff --git a/libraries/decorators/src/index.ts b/libraries/decorators/src/index.ts
@@ -9,7 +9,7 @@
  * expected behaviors and catch common mistakes.  This package is not intended to be a
  * general toolkit of language extensions or helpful macros.
  */
-declare const packageDescription: void;
+declare const packageDescription: void; // tslint:disable-line:no-unused-variable
 
 export { virtual } from './virtual';
 export { sealed } from './sealed';
diff --git a/libraries/decorators/src/test/sealed.test.ts b/libraries/decorators/src/test/sealed.test.ts
@@ -15,7 +15,7 @@ describe('@sealed tests', () => {
 
     // INCORRECT: If we did runtime validation, this would report an error
     // because the base class is marked as @sealed
-    class BadChildClass extends BaseClass {
+    class BadChildClass extends BaseClass { // tslint:disable-line:no-unused-variable
     }
 
     assert(true);
diff --git a/libraries/decorators/src/test/virtual.test.ts b/libraries/decorators/src/test/virtual.test.ts
@@ -27,7 +27,7 @@ describe('@virtual tests', () => {
         }
       }
 
-      class ChildClass extends BaseClass {
+      class ChildClass extends BaseClass { // tslint:disable-line:no-unused-variable
         @override
         public test(): void {
           super.test();
diff --git a/libraries/node-core-library/src/index.ts b/libraries/node-core-library/src/index.ts
@@ -4,6 +4,6 @@
 /**
  * Core libraries that every NodeJS toolchain project should use.
  */
-declare const packageDescription: void;
+declare const packageDescription: void; // tslint:disable-line:no-unused-variable
 
 export { JsonFile } from './JsonFile';
diff --git a/libraries/package-deps-hash/src/getPackageDeps.ts b/libraries/package-deps-hash/src/getPackageDeps.ts
@@ -45,7 +45,6 @@ export function parseGitLsTree(output: string): Map<string, string> {
  */
 export function parseGitStatus(output: string, packagePath: string): Map<string, GitStatusChangeType> {
   const changes: Map<string, GitStatusChangeType> = new Map<string, GitStatusChangeType>();
-  const filesToHash: string[] = [];
 
   /*
   * Typically, output will look something like:
diff --git a/webpack/loader-load-themed-styles/src/LoadThemedStylesLoader.ts b/webpack/loader-load-themed-styles/src/LoadThemedStylesLoader.ts
@@ -7,7 +7,7 @@
  * This simple loader wraps the loading of CSS in script equivalent to
  *  require("load-themed-styles").loadStyles('... css text ...').
  */
-declare const packageDescription: void;
+declare const packageDescription: void; // tslint:disable-line:no-unused-variable
 
 import loaderUtils = require('loader-utils');
 import { loader } from 'webpack';
diff --git a/webpack/loader-load-themed-styles/src/test/LoadThemedStylesLoader.test.ts b/webpack/loader-load-themed-styles/src/test/LoadThemedStylesLoader.test.ts
@@ -129,7 +129,6 @@ describe('LoadThemedStylesLoader', () => {
   it('correctly handles the async option set to a non-boolean', () => {
     LoadThemedStylesLoader.loadedThemedStylesPath = './testData/LoadThemedStylesMock';
 
-    const query: {} = { async: 'asdf' };
     let loaderResult: string = LoadThemedStylesLoader.pitch.call({}, './testData/MockStyle1');
     loaderResult = loaderResult.replace(/require\(\"!!/, 'require("');
     loaderResult = wrapResult(loaderResult);
diff --git a/webpack/set-webpack-public-path-plugin/src/SetPublicPathPlugin.ts b/webpack/set-webpack-public-path-plugin/src/SetPublicPathPlugin.ts
@@ -123,7 +123,6 @@ export class SetPublicPathPlugin implements Plugin {
   // This type should be "compiler," but there's another type mismatch issue so we have to stay on
   //  @types/webpack@2.2.4 for now.
   public apply(compiler: Webpack & ITapable): void {
-    const self: SetPublicPathPlugin = this;
     compiler.plugin('compilation', (compilation: ICompilation, params: Object): void => {
       compilation.mainTemplate.plugin('startup', (source: string, chunk: IChunk, hash: string) => {
         let assetOrChunkFound: boolean = chunk.chunks.length > 0;
diff --git a/webpack/set-webpack-public-path-plugin/src/index.ts b/webpack/set-webpack-public-path-plugin/src/index.ts
@@ -8,7 +8,7 @@
  *  a value specified in the arguments, optionally appended to the SystemJs baseURL
  *  property.
  */
-declare const packageDescription: void;
+declare const packageDescription: void; // tslint:disable-line:no-unused-variable
 
 export * from './SetPublicPathPlugin';
 export {

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@ describe('@sealed tests', () => {`
`15`	`15`
`16`	`16`	`// INCORRECT: If we did runtime validation, this would report an error`
`17`	`17`	`// because the base class is marked as @sealed`
`18`		`- class BadChildClass extends BaseClass {`
	`18`	`+ class BadChildClass extends BaseClass { // tslint:disable-line:no-unused-variable`
`19`	`19`	`}`
`20`	`20`
`21`	`21`	`assert(true);`