Fix case where an entrypoint has no localized resources, but async chunks do.

iclanton · iclanton · commit 080bb65b8208 · 2020-02-16T18:01:43.000-08:00
diff --git a/build-tests/localization-plugin-test-03/src/indexC.ts b/build-tests/localization-plugin-test-03/src/indexC.ts
@@ -0,0 +1,4 @@
+import(/* webpackChunkName: 'chunk-with-strings' */ './chunks/chunkWithStrings').then(({ ChunkWithStringsClass }) => {
+  const chunk = new ChunkWithStringsClass();
+  chunk.doStuff();
+});
diff --git a/build-tests/localization-plugin-test-03/webpack.config.js b/build-tests/localization-plugin-test-03/webpack.config.js
@@ -31,6 +31,7 @@ module.exports = function(env) {
     entry: {
       'localization-test-A': path.join(__dirname, 'src', 'indexA.ts'),
       'localization-test-B': path.join(__dirname, 'src', 'indexB.ts'),
+      'localization-test-C': path.join(__dirname, 'src', 'indexC.ts')
     },
     output: {
       path: path.join(__dirname, 'dist'),
diff --git a/webpack/localization-plugin/src/LocalizationPlugin.ts b/webpack/localization-plugin/src/LocalizationPlugin.ts
@@ -260,11 +260,13 @@ export class LocalizationPlugin implements Webpack.Plugin {
               }
 
               for (const chunk of chunks) {
-                let chunkHasAnyLocModules: boolean = false;
-                for (const module of chunk.getModules()) {
-                  if (EntityMarker.getMark(module)) {
-                    chunkHasAnyLocModules = true;
-                    break;
+                let chunkHasAnyLocModules: boolean = chunk.getAllAsyncChunks().size > 0;
+                if (!chunkHasAnyLocModules) {
+                  for (const module of chunk.getModules()) {
+                    if (EntityMarker.getMark(module)) {
+                      chunkHasAnyLocModules = true;
+                      break;
+                    }
                   }
                 }
 

Original file line number	Diff line number	Diff line change
`@@ -260,11 +260,13 @@ export class LocalizationPlugin implements Webpack.Plugin {`
`260`	`260`	`}`
`261`	`261`
`262`	`262`	`for (const chunk of chunks) {`
`263`		`- let chunkHasAnyLocModules: boolean = false;`
`264`		`- for (const module of chunk.getModules()) {`
`265`		`- if (EntityMarker.getMark(module)) {`
`266`		`- chunkHasAnyLocModules = true;`
`267`		`- break;`
	`263`	`+ let chunkHasAnyLocModules: boolean = chunk.getAllAsyncChunks().size > 0;`
	`264`	`+ if (!chunkHasAnyLocModules) {`
	`265`	`+ for (const module of chunk.getModules()) {`
	`266`	`+ if (EntityMarker.getMark(module)) {`
	`267`	`+ chunkHasAnyLocModules = true;`
	`268`	`+ break;`
	`269`	`+ }`
`268`	`270`	`}`
`269`	`271`	`}`
`270`	`272`