Traversal should pick up bindings in all value declarations. (purescript#2412)

LiamGoodacre · paf31 · commit 887d4130e91a · 2016-11-07T15:55:51.000+01:00
diff --git a/examples/warning/2411.purs b/examples/warning/2411.purs
@@ -0,0 +1,15 @@
+-- @shouldWarnWith ShadowedName
+module Main where
+
+import Prelude
+
+import Control.Monad.Eff (Eff)
+
+test :: forall m. Monad m => Int -> m Unit
+test x =
+  let x = unit
+  in pure x
+
+main :: Eff () Unit
+main = test 42
+
diff --git a/src/Language/PureScript/AST/Traversals.hs b/src/Language/PureScript/AST/Traversals.hs
@@ -474,7 +474,8 @@ everythingWithScope f g h i j = (f'', g'', h'', i'', \s -> snd . j'' s)
     in foldMap (f'' s') ds
   f' s (ValueDeclaration name _ bs (Right val)) =
     let s' = S.insert name s
-    in foldMap (h'' s') bs <> g'' s' val
+        s'' = S.union s' (S.fromList (concatMap binderNames bs))
+    in foldMap (h'' s') bs <> g'' s'' val
   f' s (ValueDeclaration name _ bs (Left gs)) =
     let s' = S.insert name s
         s'' = S.union s' (S.fromList (concatMap binderNames bs))
