Skip to content

Commit 94cfbab

Browse files
committed
Update DELETE to return 404 if resource doesn't exist
1 parent 4be2f30 commit 94cfbab

2 files changed

Lines changed: 13 additions & 2 deletions

File tree

src/server/router/plural.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,7 @@ module.exports = function (db, name) {
230230

231231
// DELETE /name/:id
232232
function destroy (req, res, next) {
233-
db(name).removeById(utils.toNative(req.params.id))
233+
var resource = db(name).removeById(utils.toNative(req.params.id))
234234

235235
// Remove dependents documents
236236
var removable = db._.getRemovable(db.object)
@@ -239,7 +239,10 @@ module.exports = function (db, name) {
239239
db(item.name).removeById(item.id)
240240
})
241241

242-
res.locals.data = {}
242+
if (resource) {
243+
res.locals.data = {}
244+
}
245+
243246
next()
244247
}
245248

test/server/plural.js

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -474,6 +474,14 @@ describe('Server', function () {
474474
done()
475475
})
476476
})
477+
478+
it('should respond with 404 if resource is not found', function (done) {
479+
request(server)
480+
.del('/posts/9001')
481+
.expect('Content-Type', /json/)
482+
.expect({})
483+
.expect(404, done)
484+
})
477485
})
478486

479487
describe('Static routes', function () {

0 commit comments

Comments
 (0)