Merge pull request webpack#6358 from webpack/remove_apply_plugins

TheLarkInn · web-flow · commit e8c25960a9c7 · 2018-01-22T10:40:54.000-08:00
Use hooks instead of applyPlugins
diff --git a/lib/Compilation.js b/lib/Compilation.js
@@ -1695,12 +1695,12 @@ class Compilation extends Tapable {
 			chunkGroup.checkConstraints();
 		}
 	}
-
-	applyPlugins(name, ...args) {
-		this.hooks[name.replace(/[- ]([a-z])/g, match => match[1].toUpperCase())].call(...args);
-	}
 }
 
+Compilation.prototype.applyPlugins = util.deprecate(function(name, ...args) {
+	this.hooks[name.replace(/[- ]([a-z])/g, match => match[1].toUpperCase())].call(...args);
+}, "Compilation.applyPlugins is deprecated. Use new API on `.hooks` instead");
+
 Object.defineProperty(Compilation.prototype, "moduleTemplate", {
 	configurable: false,
 	get: util.deprecate(function() {
diff --git a/lib/HotModuleReplacementPlugin.js b/lib/HotModuleReplacementPlugin.js
@@ -130,7 +130,7 @@ module.exports = class HotModuleReplacementPlugin {
 							compilation.assets[filename] = source;
 							hotUpdateMainContent.c[chunkId] = true;
 							currentChunk.files.push(filename);
-							compilation.applyPlugins("chunk-asset", currentChunk, filename);
+							compilation.hooks.chunkAsset.call("HotModuleReplacementPlugin", currentChunk, filename);
 						}
 					} else {
 						hotUpdateMainContent.c[chunkId] = false;

Original file line number	Diff line number	Diff line change
`@@ -1695,12 +1695,12 @@ class Compilation extends Tapable {`
`1695`	`1695`	`chunkGroup.checkConstraints();`
`1696`	`1696`	`}`
`1697`	`1697`	`}`
`1698`		`-`
`1699`		`- applyPlugins(name, ...args) {`
`1700`		`- this.hooks[name.replace(/[- ]([a-z])/g, match => match[1].toUpperCase())].call(...args);`
`1701`		`- }`
`1702`	`1698`	`}`
`1703`	`1699`
	`1700`	`+Compilation.prototype.applyPlugins = util.deprecate(function(name, ...args) {`
	`1701`	`+ this.hooks[name.replace(/[- ]([a-z])/g, match => match[1].toUpperCase())].call(...args);`
	`1702`	+}, "Compilation.applyPlugins is deprecated. Use new API on `.hooks` instead");
	`1703`	`+`
`1704`	`1704`	`Object.defineProperty(Compilation.prototype, "moduleTemplate", {`
`1705`	`1705`	`configurable: false,`
`1706`	`1706`	`get: util.deprecate(function() {`
Original file line number	Diff line number	Diff line change
`@@ -130,7 +130,7 @@ module.exports = class HotModuleReplacementPlugin {`
`130`	`130`	`compilation.assets[filename] = source;`
`131`	`131`	`hotUpdateMainContent.c[chunkId] = true;`
`132`	`132`	`currentChunk.files.push(filename);`
`133`		`- compilation.applyPlugins("chunk-asset", currentChunk, filename);`
	`133`	`+ compilation.hooks.chunkAsset.call("HotModuleReplacementPlugin", currentChunk, filename);`
`134`	`134`	`}`
`135`	`135`	`} else {`
`136`	`136`	`hotUpdateMainContent.c[chunkId] = false;`